From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: joro@8bytes.org, will@kernel.org, marcan@marcan.st,
sven@svenpeter.dev, robin.murphy@arm.com, robdclark@gmail.com,
baolu.lu@linux.intel.com, orsonzhai@gmail.com,
baolin.wang7@gmail.com, zhang.lyra@gmail.com,
jean-philippe@linaro.org, alex.williamson@redhat.com,
kevin.tian@intel.com, suravee.suthikulpanit@amd.com,
alyssa@rosenzweig.io, dwmw2@infradead.org,
mjrosato@linux.ibm.com, gerald.schaefer@linux.ibm.com,
thierry.reding@gmail.com, vdumpa@nvidia.com,
jonathanh@nvidia.com, cohuck@redhat.com,
thunder.leizhen@huawei.com, christophe.jaillet@wanadoo.fr,
chenxiang66@hisilicon.com, john.garry@huawei.com,
yangyingliang@huawei.com, iommu@lists.linux-foundation.org,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-tegra@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [PATCH v5 4/5] vfio/iommu_type1: Clean up update_dirty_scope in detach_group()
Date: Fri, 29 Jul 2022 14:34:34 -0300 [thread overview]
Message-ID: <YuQaKpvsJICiFC6N@nvidia.com> (raw)
In-Reply-To: <20220701214455.14992-5-nicolinc@nvidia.com>
On Fri, Jul 01, 2022 at 02:44:54PM -0700, Nicolin Chen wrote:
> All devices in emulated_iommu_groups have pinned_page_dirty_scope
> set, so the update_dirty_scope in the first list_for_each_entry
> is always false. Clean it up, and move the "if update_dirty_scope"
> part from the detach_group_done routine to the domain_list part.
>
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
> drivers/vfio/vfio_iommu_type1.c | 27 ++++++++++++---------------
> 1 file changed, 12 insertions(+), 15 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2022-07-29 17:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 21:44 [PATCH v5 0/5] cover-letter: Simplify vfio_iommu_type1 attach/detach routine Nicolin Chen
2022-07-01 21:44 ` [PATCH v5 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group Nicolin Chen
2022-07-29 17:30 ` Jason Gunthorpe
2022-07-01 21:44 ` [PATCH v5 2/5] vfio/iommu_type1: Prefer to reuse domains vs match enforced cache coherency Nicolin Chen
2022-07-01 21:44 ` [PATCH v5 3/5] vfio/iommu_type1: Remove the domain->ops comparison Nicolin Chen
2022-07-29 17:33 ` Jason Gunthorpe
2022-07-01 21:44 ` [PATCH v5 4/5] vfio/iommu_type1: Clean up update_dirty_scope in detach_group() Nicolin Chen
2022-07-29 17:34 ` Jason Gunthorpe [this message]
2022-07-01 21:44 ` [PATCH v5 5/5] vfio/iommu_type1: Simplify group attachment Nicolin Chen
2022-07-06 17:42 ` [PATCH v5 0/5] cover-letter: Simplify vfio_iommu_type1 attach/detach routine Alex Williamson
2022-07-06 17:53 ` Nicolin Chen
2022-07-06 18:03 ` Alex Williamson
2022-07-13 23:57 ` Nicolin Chen
2022-07-26 18:32 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuQaKpvsJICiFC6N@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=alyssa@rosenzweig.io \
--cc=baolin.wang7@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=chenxiang66@hisilicon.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cohuck@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=john.garry@huawei.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=orsonzhai@gmail.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=sven@svenpeter.dev \
--cc=thierry.reding@gmail.com \
--cc=thunder.leizhen@huawei.com \
--cc=vdumpa@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=yangyingliang@huawei.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).