From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D71E1C0502C for ; Tue, 30 Aug 2022 07:01:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230347AbiH3HBQ (ORCPT ); Tue, 30 Aug 2022 03:01:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230348AbiH3HBL (ORCPT ); Tue, 30 Aug 2022 03:01:11 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72A2F9F77A; Tue, 30 Aug 2022 00:01:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 87B49B816AA; Tue, 30 Aug 2022 07:01:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46FD5C433D6; Tue, 30 Aug 2022 07:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661842863; bh=1m8t3XQYq2uVxf9hIZZQ7ueuqje2AiVRqFHNHbPJSVE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JbQLeUv1wrIEeCeDusHAqgn20ilbVFg38RzUBjY3XCBvhC7gvFbpdxoOB1daufk3q uWiLWIjwoMw5re0DiTvYJElcLl/Tq2jgmmIwne4LMNkqmRNwIqvR0CfX11Vbp+DtO+ n/dGxrL7CYGzi1hxsF2YQFAzBm/2cEHKFgzeDY+udVqelXAa90GLI6WK6Pao9enHyg JiyNBB3Qv7gYobpGlyp1QhiE0W6d//d72v4rrFve6f8vhqauChOjMarwFgLgWKIZbz G6u7ZkAPWmC0AqblXc7DydMfWDwJoleW6cN0QFHVZsnz+ZLe4LSItDdgPL6fJyH1zf jFZ5BbFTn4ocg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oSvFH-0007Sc-Ga; Tue, 30 Aug 2022 09:01:11 +0200 Date: Tue, 30 Aug 2022 09:01:11 +0200 From: Johan Hovold To: Vinod Koul Cc: Johan Hovold , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 00/30] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix Message-ID: References: <20220714124333.27643-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Aug 30, 2022 at 10:36:43AM +0530, Vinod Koul wrote: > On 14-07-22, 14:43, Johan Hovold wrote: > > When adding support for SC8280XP to the QMP PHY driver I noticed that > > the PHY provider child node was not described by the current DT schema. > > > > The SC8280XP PHYs also need a second fixed-divider PIPE clock > > ("pipediv2") and I didn't want to have to add a bogus "lane" suffix to > > the clock name just to match the current "pipe0" name so I decided to > > deprecate the unnecessary suffix in the current binding instead. > > > > To be able to add the missing child-node schema and handle device > > specifics like additional PIPE clocks, it quickly became obvious that > > the binding needs to be split up. > > > > This series clean up and fixes some issue with the current schema before > > splitting it up in separate schemas for PCIe, UFS and USB and adding > > missing parts like the child PHY provider nodes. > > > > The MSM8996 PCIe PHY gets its own schema as this is the only non-combo > > PHY that actually provides more than one PHY per IP block. Note that the > > "lane" suffix is still unnecessary and misleading. > > > > The final patches add support for the updated binding to the (recently > > split up) PHY drivers. Included is also a related combo PHY cleanup. > > This fails at patch 2 for me on v6.0-rc1, please rebase and resend Are you sure you haven't applied anything to your local tree that causes this? I just tried fetching the v3 series from lore and it applies just fine on top of 6.0-rc1. Note that if you've added a new compatible string locally, the second patch which sorts the compatible strings is likely to fail to apply. Johan