From: Mark Brown <broonie@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Andrew Halaney <ahalaney@redhat.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: qcom-rpmh: Implement get_optimum_mode(), not set_load()
Date: Tue, 23 Aug 2022 14:06:30 +0100 [thread overview]
Message-ID: <YwTQ1i5s5cwowRss@sirena.org.uk> (raw)
In-Reply-To: <CAD=FV=V_V-M1fJmeWH_=wG4GB9GERL9ToAZTwAjX9i-6k6QkWA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
On Mon, Aug 22, 2022 at 01:13:55PM -0700, Doug Anderson wrote:
> I guess at this point I'll wait for Mark to give his suggestion for
> what to do. Options I'm aware of:
> a) ${SUBJECT} patch was written as a cleanup as per Mark's request and
> we could just revert it.
> b) We could make it so that failures to get the input/output voltages
> doesn't count as an error when going through the get_optimum_mode()
> path.
We could push the checks for a valid voltage down into the drivers, a
lot of things aren't particularly sensitive to the output voltage here
and are much more sensitive to the current draw. Depending on people's
attitudes to DT stability for Qualcomm platforms we could also fix the
affected DTs as well, though that doesn't stop us handling this in the
core too.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-08-23 16:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 17:20 [PATCH] regulator: qcom-rpmh: Implement get_optimum_mode(), not set_load() Douglas Anderson
2022-07-26 20:43 ` Mark Brown
2022-08-15 15:44 ` Mark Brown
2022-08-22 19:31 ` Andrew Halaney
2022-08-22 20:04 ` Andrew Halaney
2022-08-22 20:13 ` Doug Anderson
2022-08-23 13:06 ` Mark Brown [this message]
2022-08-23 20:18 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwTQ1i5s5cwowRss@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@somainline.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox