From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E42C3C38145 for ; Tue, 6 Sep 2022 19:04:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229647AbiIFTEU (ORCPT ); Tue, 6 Sep 2022 15:04:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbiIFTET (ORCPT ); Tue, 6 Sep 2022 15:04:19 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E112F8C45A for ; Tue, 6 Sep 2022 12:04:17 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id q15-20020a17090a304f00b002002ac83485so8479050pjl.0 for ; Tue, 06 Sep 2022 12:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=u5M6QxdAPtDOUZYM968YPfYQgKBWh+diykgOvWRU0/o=; b=d+qIdUiwBS4vrHLafCK0ZewwWsNsAresJB4Ha48hicYnkPEiiLzJJ9HIYP5gpQp9Q6 MLY24WiB+HBZQDlXE+zB3hVXOuJsZup37ch73XmdcCyJEaqM6DmnXc7twtV1wW4aJiwZ yYPBJ9HdxQ6Kh4A5xJuZHjD7u0cBwmHsZUr/o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=u5M6QxdAPtDOUZYM968YPfYQgKBWh+diykgOvWRU0/o=; b=6rrg1AJNcGhKNakYu+i0YJDYDKXppyiye5V80pycsWwioJ3/zmL5EUzPTCx5a18ts1 YVu9tetL4YJOKBRlTNM1XLsePNEWl2L1Nz/z/KcnRSaIcAoA4RBN22mUFeoYL4GnoDXw +biMs8f7ZQpeGHDdCC2LrAQmmyGq5NVEU17PzcNJhOhbmwEqLRD6vYQwadMuf/o7XMu9 PMIs0SqyLAZCAJHel9zRk2icFTrZNEHjoxzeqFpe7wwAR2vUu+D57SRZlqGy8TGq1u1z lZwC69oqr6ahhNcPBURv0ibBG0c1eOfGZmBPS23m0m+tMd9WlvxKzAir92NjdqtErqHY oHkw== X-Gm-Message-State: ACgBeo2yZq7uL2XsPRwwOJRp5AmJqwyTL19gVc1t7vXHPLMwpwEtz3We /ny6FZLRSLuqRpHycnwTlsOJDQ== X-Google-Smtp-Source: AA6agR7U2bm4Qk9QDupReQP6foEFsmxKNcPMJZV3bm3IXBlg6jD5XNYwq9ld8GkXR0taSv15gfL9/A== X-Received: by 2002:a17:902:be01:b0:176:8bc3:b379 with SMTP id r1-20020a170902be0100b001768bc3b379mr51706pls.109.1662491057388; Tue, 06 Sep 2022 12:04:17 -0700 (PDT) Received: from localhost ([2620:15c:11a:202:acea:5f9a:4de:10c7]) by smtp.gmail.com with UTF8SMTPSA id q13-20020a170902dacd00b001743be790b4sm10337536plx.215.2022.09.06.12.04.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Sep 2022 12:04:16 -0700 (PDT) Date: Tue, 6 Sep 2022 12:04:14 -0700 From: Matthias Kaehlcke To: Doug Anderson Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm , Krishna Kurapati , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH v2] arm64: dts: qcom: sc7180: Configure USB as wakeup source Message-ID: References: <20220901102946.v2.1.I347ea409ee3134bd32a29e33fecd1a6ef32085a0@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Doug, On Tue, Sep 06, 2022 at 11:33:56AM -0700, Doug Anderson wrote: > Hi, > > On Thu, Sep 1, 2022 at 10:29 AM Matthias Kaehlcke wrote: > > > > The dwc3 USB controller of the sc7180 supports USB remote > > wakeup, configure it as a wakeup source. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > > > Changes in v2: > > - use qcom/arm64-for-6.1 as base, v1 was unintendedly based on a > > downstream branch that was used for testing > > > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > index e8debb0da411..af5bab27eaf3 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > @@ -2782,6 +2782,8 @@ usb_1: usb@a6f8800 { > > <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3 0>; > > interconnect-names = "usb-ddr", "apps-usb"; > > > > + wakeup-source; > > + > > The patch documenting this property has landed in commit 416b61893860 > ("dt-bindings: usb: qcom,dwc3: add wakeup-source property"). I guess > the only question is whether this should be in the general sc7180 > device tree file or just for trogdor. I had a similar comment on the patch for sc7280 [1], there the rationale for putting the property into the .dtsi of the SoC was that the wakeup capability is provided by the SoC. For sc8280xp.dtsi the property is also in the .dtsi of the SoC: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/tree/arch/arm64/boot/dts/qcom/sc8280xp.dtsi?h=arm64-for-6.1#n1315 > Any chance it could cause problems for devices that aren't designed like > trogdor? Probably not in a functional sense, however power consumption during system suspend is slightly higher (2-3 mW) when USB wakeup is enabled. Boards can disable wakeup by deleting the property in their .dtsi file, though it is not necessarily evident that this is an option to reduce power consumption. [1] https://patchwork.kernel.org/project/linux-arm-msm/patch/1649321104-31322-7-git-send-email-quic_c_sanm@quicinc.com/