From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-arm-msm-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 55B37C32771
	for <linux-arm-msm@archiver.kernel.org>; Sat, 24 Sep 2022 07:18:45 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233424AbiIXHSo (ORCPT
        <rfc822;linux-arm-msm@archiver.kernel.org>);
        Sat, 24 Sep 2022 03:18:44 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51996 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233310AbiIXHSg (ORCPT
        <rfc822;linux-arm-msm@vger.kernel.org>);
        Sat, 24 Sep 2022 03:18:36 -0400
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 478F313B03F;
        Sat, 24 Sep 2022 00:18:35 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id D4524B80DB0;
        Sat, 24 Sep 2022 07:18:33 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C485AC433C1;
        Sat, 24 Sep 2022 07:18:31 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1664003912;
        bh=WYcPEBIbFsLgcirOxORHxczcQ1qEYSvFDeSAKl0GsoM=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=MUnMKX06OXEQtjj6TrOXPUGYJOSPl8c0/z4c/LcAqbs4lYAsqs0aMTlPGdhgY99dn
         uapU1niSg/8mfJR1qbFbhKe+gNiZ9RNSStgNRQwt2HfCxXsKqQZUtGEDkdBSjNrTFn
         CEKzj0hE0pJzRifgkJ0gTAXLE6tpsET7VQFxuhLEjdaBm0pzdrS/PCrXKj4Kl51/1G
         KlQ5hbgPECCsldIaXDntphans183VJuEhIjRoZOXD+W3ctoIc8hLW0fasZEWcNARPv
         rYNbcdIyhwR7nAak/2wwuB90/nMPY8KKPyFyhe8balrROGOUQrFnz/J/3XXINgDbeX
         lg8TdAJtZAFHQ==
Date:   Sat, 24 Sep 2022 12:48:28 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Dongliang Mu <dzm91@hust.edu.cn>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Vivek Gautam <vivek.gautam@codeaurora.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Jaehoon Chung <jh80.chung@samsung.com>,
        Dongliang Mu <mudongliangabcd@gmail.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: qualcomm:  call clk_disable_unprepare in the error
 handling
Message-ID: <Yy6vRNfEBDUqebqX@matsya>
References: <20220914051334.69282-1-dzm91@hust.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220914051334.69282-1-dzm91@hust.edu.cn>
Precedence: bulk
List-ID: <linux-arm-msm.vger.kernel.org>
X-Mailing-List: linux-arm-msm@vger.kernel.org

On 14-09-22, 13:13, Dongliang Mu wrote:
> From: Dongliang Mu <mudongliangabcd@gmail.com>
> 
> Smatch reports the following error:
> 
> drivers/phy/qualcomm/phy-qcom-usb-hsic.c:82 qcom_usb_hsic_phy_power_on()
> warn: 'uphy->cal_clk' from clk_prepare_enable() not released on lines:
> 58.
> drivers/phy/qualcomm/phy-qcom-usb-hsic.c:82 qcom_usb_hsic_phy_power_on()
> warn: 'uphy->cal_sleep_clk' from clk_prepare_enable() not released on
> lines: 58.
> drivers/phy/qualcomm/phy-qcom-usb-hsic.c:82 qcom_usb_hsic_phy_power_on()
> warn: 'uphy->phy_clk' from clk_prepare_enable() not released on lines:
> 58.
> 
> Fix this by calling proper clk_disable_unprepare calls.

Applied, thanks

-- 
~Vinod