Re: [PATCH -next] usb: typec: qcom-pmic-typec: Switch to use dev_err_probe() helper

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Thu, Sep 22, 2022 at 09:57:08PM +0800, Yang Yingliang wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/qcom-pmic-typec.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/typec/qcom-pmic-typec.c b/drivers/usb/typec/qcom-pmic-typec.c
> index a0454a80c4a2..432ea62f1bab 100644
> --- a/drivers/usb/typec/qcom-pmic-typec.c
> +++ b/drivers/usb/typec/qcom-pmic-typec.c
> @@ -195,9 +195,8 @@ static int qcom_pmic_typec_probe(struct platform_device *pdev)
>  
>  	qcom_usb->role_sw = fwnode_usb_role_switch_get(dev_fwnode(qcom_usb->dev));
>  	if (IS_ERR(qcom_usb->role_sw)) {
> -		if (PTR_ERR(qcom_usb->role_sw) != -EPROBE_DEFER)
> -			dev_err(dev, "failed to get role switch\n");
> -		ret = PTR_ERR(qcom_usb->role_sw);
> +		ret = dev_err_probe(dev, PTR_ERR(qcom_usb->role_sw),
> +				    "failed to get role switch\n");
>  		goto err_typec_port;
>  	}
>  
> -- 
> 2.25.1

-- 
heikki