From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8FA91B4F04; Tue, 10 Dec 2024 14:02:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733839362; cv=none; b=o1sqz2W5uN6IKwrfHClgRVH9H5OKCFSrDkOfaJqCfI4cBfFbS7dBg2f7PpAqW6amdKXuxWLQcYn8nehIoqz0WLP8a8oMrNlkqCnOV5gnjip9IjtXltiI4rG6gyKYsVFBJmQl0nCMDYoOUliXJNLYsagYdxSGL/cmjafWWt91u7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733839362; c=relaxed/simple; bh=qKuGnKrDI8tSu8y0laNgchv/TAlzf72FKxm9pJA01ek=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YgO37iWx0LoeQcCE3u8uHouXdjxA7TeDeiw/OljJzNrmzXnmj+iV+32XdjibkEbz0yXor4E+wxtfPYyJnnQtKaV3ZkZ5OHI58Qn/XSLm11Wx6gThQOQSN4lHFWi+erWhHvBcQixMeOFPGXiLjlAIA3azaZ3FTqo1JNuJ23H1QHU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=p7pee7gc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="p7pee7gc" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BA8P2I8015737; Tue, 10 Dec 2024 14:02:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qxWpVhRjhZwE295T3kgsrVOGaciQb5Kgk+jkfYqg6CQ=; b=p7pee7gcu4pMXx5H oDfqgVsDvVoo8msqleGs1OtDwLKxo7COWn80JKt1NCZ2LfgnMh7jpu9dXVT/xz6s N6bn1uIKcceJLucyBabLKtYDQGQzoAoEvAu012X7HEtQdDnwsdXTR1dkR7J3XkRj ZkqvqTUw3TGxRwfCU5UYrtDiualMkEUZbyMobqdcMEHgm9I5P66n0dwgvcWQv39Z BIWGI8Yk7axJ7YwuUs/J6dFzP6F8igWNXp974sLwvInX1lIHfplVpm+xZLcfbpLz +/hEq9TIwhq1SIrwyZGzDqpDpqWSz/3kuE2q8xyMorKj4aOwuB7oVL595AQET7Mm 79+sFQ== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43dy8tv808-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Dec 2024 14:02:32 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4BAE2VRx014982 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Dec 2024 14:02:31 GMT Received: from hu-wasimn-hyd.qualcomm.com (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 10 Dec 2024 06:02:24 -0800 Date: Tue, 10 Dec 2024 19:32:16 +0530 From: Wasim Nazir To: Krzysztof Kozlowski CC: Dmitry Baryshkov , Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Subject: Re: [PATCH v3 5/5] arm64: dts: qcom: Add support for QCS9075 Ride & Ride-r3 Message-ID: References: <9e351979-be01-4d38-9b94-cc23efac4c3f@kernel.org> <8cf9edc0-a0cb-4fd0-b10e-2138784dfba3@kernel.org> <5782d7c6-1a75-4f15-8942-387742e0ae09@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: gyDQnnuAzdRtmsRSHi2HyCj0R63x__Eb X-Proofpoint-GUID: gyDQnnuAzdRtmsRSHi2HyCj0R63x__Eb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 priorityscore=1501 mlxlogscore=790 clxscore=1015 mlxscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412100105 On Tue, Dec 10, 2024 at 12:50:51PM +0100, Krzysztof Kozlowski wrote: > On 10/12/2024 10:24, Wasim Nazir wrote: > > On Tue, Dec 10, 2024 at 08:25:34AM +0100, Krzysztof Kozlowski wrote: > >> On 10/12/2024 00:25, Dmitry Baryshkov wrote: > >>>>>>>> 9100 & 9075 are different from “safe” perspective. They differ in > >>>>>>>> changes related to thermal which will be added later in devicetree. > >>>>>>> > >>>>>>> Since this can't be inferred from just looking at the changes, please > >>>>>>> make sure to add that to the commit message > >>>>>> > >>>>>> Any include of other DTS is clear sign something is odd here. Including > >>>>>> multiple times without any added nodes is showing these are not real > >>>>>> products/boards . > >>>>> > >>>>> We're adding DTS to reuse the common board changes, with plans to > >>>>> include the differences in upcoming patches. To provide more clarity, I > >>>>> will include patches in this series to highlight the differences between > >>>>> the 9100 and 9075 boards. > >>>> > >>>> Sure, still do not include DTS. Just like C files don't include C files. > >>> > >>> So, is the solution simple, rename .dts to .dtsi and include it from > >>> both .dts files? > >> > >> For example. This leads to more questions - what is common here? We do > >> not create shared DTSI files just because someone wants, but to really > >> note shared components or shared designs. > >> > > > > We can reuse the common dtsi for ride boards, i.e., sa8775p-ride.dtsi, > > and then add board-specific changes in the corresponding files. > > > So you will create shared DTSI because "someone wants"? Did you read the > question above and valid reasons/answers to it? > Sorry, if I couldn't able to answer your question. We will not be creating any new DTSI files. Since QCS9075 is derived from SA8775P, we will be reusing the existing common DTSI files for the ride boards of the SA8775P and its derivative SoCs. Here is the change reference for common ride dtsi: https://lore.kernel.org/all/20240627114212.25400-3-brgl@bgdev.pl/ Please let me know if I missed anything. > > > > > If this approach is acceptable, I can proceed with sending the > > next patch series. I hope this will help clarify things further. > > Best regards, > Krzysztof Thanks & Regards, Wasim