From: Johan Hovold <johan@kernel.org>
To: Marc Zyngier <maz@kernel.org>, Sibi Sankar <quic_sibis@quicinc.com>
Cc: Stephan Gerhold <stephan.gerhold@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Xilin Wu <wuxilin123@gmail.com>, Abel Vesa <abel.vesa@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Aleksandrs Vinarskis <alex.vinarskis@gmail.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies
Date: Tue, 10 Dec 2024 16:38:03 +0100 [thread overview]
Message-ID: <Z1hgW-_pqqCpIwH0@hovoldconsulting.com> (raw)
In-Reply-To: <86ttbbsm69.wl-maz@kernel.org>
On Tue, Dec 10, 2024 at 01:27:26PM +0000, Marc Zyngier wrote:
> On Tue, 10 Dec 2024 13:18:20 +0000,
> Johan Hovold <johan@kernel.org> wrote:
> >
> > On Tue, Dec 10, 2024 at 10:07:31AM +0100, Stephan Gerhold wrote:
> > > On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> > > (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> > > are actually powered by &vreg_l2j_1p2.
> > >
> > > Since most X1E device trees just mirror the power supplies from the
> > > x1e80100-crd device tree, this series fixes up all the X1E boards with
> > > the same change.
> >
> > Nice find! I've confirmed that this matches both the CRD and T14s
> > schematics.
>
> Can someone with access to the schematics confirm that the devkit
> indeed has the same supplies?
Sibi, can you confirm our assumption that these definitions were copied
from the CRD devicetree and need to be fixed like this also for the
devkit?
Johan
next prev parent reply other threads:[~2024-12-10 15:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 9:07 [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies Stephan Gerhold
2024-12-10 9:07 ` [PATCH 1/8] arm64: dts: qcom: x1e001de-devkit: " Stephan Gerhold
2024-12-10 9:07 ` [PATCH 2/8] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: " Stephan Gerhold
2024-12-10 9:07 ` [PATCH 3/8] arm64: dts: qcom: x1e80100-asus-vivobook-s15: " Stephan Gerhold
2024-12-13 20:39 ` Maud Spierings
2024-12-10 9:07 ` [PATCH 4/8] arm64: dts: qcom: x1e80100-crd: " Stephan Gerhold
2024-12-10 9:07 ` [PATCH 5/8] arm64: dts: qcom: x1e80100-dell-xps13-9345: " Stephan Gerhold
2024-12-10 20:44 ` Aleksandrs Vinarskis
2024-12-11 11:35 ` Tudor, Laurentiu
2024-12-11 11:42 ` Johan Hovold
2024-12-10 9:07 ` [PATCH 6/8] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: " Stephan Gerhold
2024-12-10 9:07 ` [PATCH 7/8] arm64: dts: qcom: x1e80100-microsoft-romulus: " Stephan Gerhold
2024-12-12 23:49 ` Konrad Dybcio
2024-12-10 9:07 ` [PATCH 8/8] arm64: dts: qcom: x1e80100-qcp: " Stephan Gerhold
2024-12-10 13:18 ` [PATCH 0/8] arm64: dts: qcom: x1e*: " Johan Hovold
2024-12-10 13:27 ` Marc Zyngier
2024-12-10 15:38 ` Johan Hovold [this message]
2024-12-12 15:47 ` Konrad Dybcio
2024-12-26 22:38 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1hgW-_pqqCpIwH0@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=alex.vinarskis@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=quic_sibis@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stephan.gerhold@linaro.org \
--cc=wuxilin123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox