Re: mhi resume failure on reboot with 6.13-rc2

[Johan Hovold <johan@kernel.org>]

On Wed, Dec 11, 2024 at 08:23:15PM +0530, Manivannan Sadhasivam wrote:
> On Wed, Dec 11, 2024 at 03:17:22PM +0100, Johan Hovold wrote:

> > I just hit the following modem related error on reboot of the x1e80100
> > CRD for the second time with 6.13-rc2:
> > 
> > 	[  138.348724] shutdown[1]: Rebooting.
> >         [  138.545683] arm-smmu 3da0000.iommu: disabling translation
> >         [  138.582505] mhi mhi0: Resuming from non M3 state (SYS ERROR)
> >         [  138.588516] mhi-pci-generic 0005:01:00.0: failed to resume device: -22
> >         [  138.595375] mhi-pci-generic 0005:01:00.0: device recovery started
> >         [  138.603841] wwan wwan0: port wwan0qcdm0 disconnected
> >         [  138.609508] wwan wwan0: port wwan0mbim0 disconnected
> >         [  138.615137] wwan wwan0: port wwan0qmi0 disconnected
> >         [  138.702604] mhi mhi0: Requested to power ON
> >         [  139.027494] mhi mhi0: Power on setup success
> >         [  139.027640] mhi mhi0: Wait for device to enter SBL or Mission mode
> > 
> > and then the machine hangs.
> > 
> > Do you know if there are any changes since 6.12 that could cause this?
> 
> Only 3 changes went in for 6.13-rc1 and they shouldn't cause any issues. One
> caused the regression with pcim_iomap_region(), but you submitted a fix for
> that and other two were trivial.

Ok, thanks.

> From the log, 'mhi mhi0: Resuming from non M3 state (SYS ERROR)' indicates that
> the firmware got crashed while resuming. So maybe you should check with ath12k
> folks.

This is the modem so I don't think the ath12k wifi folks are to blame
here.

It may be an older, existing issue that started triggering due to
changes in timing or something.

Is there anything you can do on the mhi side to prevent it from blocking
reboot/power off?

I'm guessing the mhi timeout, which I've hit in other paths like resume,
may trigger after a minute or two even if I never waited that long
before hitting reset during reboot.

Johan