From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] soc: qcom: llcc: Enable LLCC_WRCACHE at boot on X1
Date: Fri, 13 Dec 2024 15:10:01 +0100 [thread overview]
Message-ID: <Z1xAOQWFy2J7zbdC@hovoldconsulting.com> (raw)
In-Reply-To: <40bdbb34-94a5-4500-a660-57a530f066c8@oss.qualcomm.com>
On Fri, Dec 13, 2024 at 01:24:24PM +0100, Konrad Dybcio wrote:
> On 13.12.2024 9:42 AM, Johan Hovold wrote:
> > On Thu, Dec 12, 2024 at 05:32:24PM +0100, Konrad Dybcio wrote:
> >> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> >>
> >> Do so in accordance with the internal recommendations.
> >
> > Your commit message is still incomplete as it does not really say
> > anything about what this patch does, why this is needed or what the
> > implications are if not merging this patch.
>
> I'm not sure I can say much more here..
If you don't know what this slice is used for or what impact enabling it
has then saying so in the commit message is also useful information.
But you should be able to provide some background for reviewers, stable
maintainers, other devs, posterity, ...
> > How would one determine that this patch is a valid candidate for
> > backporting, for example.
>
> "suboptimal hw presets"
I'm sure the patch is correct, but spell something out in the commit
message.
Johan
prev parent reply other threads:[~2024-12-13 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 16:32 [PATCH v2] soc: qcom: llcc: Enable LLCC_WRCACHE at boot on X1 Konrad Dybcio
2024-12-13 8:42 ` Johan Hovold
2024-12-13 12:24 ` Konrad Dybcio
2024-12-13 14:10 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1xAOQWFy2J7zbdC@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox