From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9663519E97B for ; Tue, 28 Jan 2025 10:56:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738061766; cv=none; b=XFYQkTNYsVyIGOO11/OfP8TJ0UEBqMJ6FCd1e2qbtarDaoAcFUwYUFbCrdoJg9RE2tCpQQGgzRtFsenYrJ4F8FzFh4dEH0OYoTNqzBXNmVTf96gku2UafrU5a4KAY4JOrBePTITq0K/nePwzRriUYckHchGOGX1P0MS7qYPXb8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738061766; c=relaxed/simple; bh=cArZVZaLci+50MPkg01ZYsHm0mt+lKxiUKiDtQqfBEU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HIffk6YMPXuj27mpJeTkXH4hSXRVLlAzVhwlrc7cLfjFxrILMie5+mLUCvDkDC80D6H31lF9zK1WWy5dB822hYmUcfNoyZxE/YINwNwbYfNiyLDSmacGlnu8OIZN6uj5dRswetfPKkoGLW/vEFR3+zdfFsy+H7gDR4U5D+zhKWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=TTogRCKf; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TTogRCKf" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-436a39e4891so36534635e9.1 for ; Tue, 28 Jan 2025 02:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738061762; x=1738666562; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Xsh2bdBHY9NmVDqj8pBitppRTEEhQQ7ykuHHJrKgvjM=; b=TTogRCKfC7iUiosD0TVDE0EqQDuGZ+JQKKIUCBgvk3Kb36bqTKi4zVwWuKR6eWVE4L WHXV0L5+gmpBV8r9bAJ8dU5l/AQxghgjtFHXcNWRIKmSncwxKN+DTNACifWF7u0qlldK 3pJyl0fSoLatrt+9o7gujzuxbYaFPsKxTicg3reWaEgejoMJt94ERUAWDL1w2JCSApbI GynVYnjIBxpA5qDv2i/rtHoethHPg3+maKuS+8dmFbL67hBCu6b9zRY5wZiXbuj58Zk7 ohaPmtXerBYRmK5FhHifkLZ35o0pZgfBmsYyYAxsoqzUpRj6zEwWOaUJLpsWNp+pF34y /kuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738061762; x=1738666562; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xsh2bdBHY9NmVDqj8pBitppRTEEhQQ7ykuHHJrKgvjM=; b=aXo29Ty0Tud1wLEC2WGYvx7QHSUCFKsKcbfZKG+qL/lBMUwhuVuylnky9Hh6vlC/Fb ds2dYZ+qe3BRCyNCT/l6uVkaVkiOK2/H7+3QxBQj/WGRfCid8z5pCGqyE5/j+/LLzPnW mrqODyPKrMtboGTlx/u1ZkXKKP9HJirmyLiWYZLkX4jlcLQqAsXk4ItTMUtqrpPSV+Ig 9cC9cSR75UDIqWtl8hqC3d9+5fxN+DgqzftdbaBxDTfo4s80RtxJ64nTprDCzkPtPHjX PGlX1UIf9LP/+yEVKPKYoDZ5iW4jHxa0EfmOGDOST3svlGzE8Q+1XnwI2L/fxnC7E5wc lRWw== X-Forwarded-Encrypted: i=1; AJvYcCVLRQd/8Ptvc9WIv6WsXYSK7cKnCvFsTCw6Te+y1dNZkpyqieRQLzeEU4CZbuoqV/kXuFvmuAurQPH3hGoN@vger.kernel.org X-Gm-Message-State: AOJu0YxepVE8JH6F3H7GQyZWdZN5kxMlZsBlcXFU7FquIF+CMG56HOuy H5KTtWUfVlilwgsGYLHEzI/aSTOI8kdHM0lAKYCYZwzSgtKCcaEBu46nVLsbA5w= X-Gm-Gg: ASbGncvZ7H5YqzUawnrhF/+KTpmD6A0AqoUiVXWji+MzOR1OXlDPXyhp8IEWZpPsCr5 dn4c1bIWNBiRhiSuq0D5rTdv6LT9VTT2Jm/gSoVE0HvGzS66fyMeLkF6MU0yuP0rtvqFt6e2SSn qEFXemIa7fU1kOaDabUlkIZmdTNyM+miqW8Vo4jkXaVz0Mp+lPkzZRb7OVSfO8hGfg4OVqtsPrl Nv+sWwRb9Rf+ufl5ROR9I9lozHHBnQY2Yx5Zf+Xym/s79YyeVmugC1+tVouxEXVX5KvWOtVKrfH 5AMTdX7rxD64SL3HN2366pqxLrU= X-Google-Smtp-Source: AGHT+IFFfd66YWcV3wlAUFzLoGU3ZbpAAot76mCsg4WzevFEyoKcFSJu+ml7EishK6BP/p1tw+IBNg== X-Received: by 2002:a05:600c:348f:b0:430:563a:b20a with SMTP id 5b1f17b1804b1-438913d693bmr486492905e9.11.1738061761800; Tue, 28 Jan 2025 02:56:01 -0800 (PST) Received: from linaro.org ([2a02:2454:ff21:ef30:3210:3bfd:4b47:59da]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a176538sm13555756f8f.8.2025.01.28.02.56.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 02:56:01 -0800 (PST) Date: Tue, 28 Jan 2025 11:55:56 +0100 From: Stephan Gerhold To: Konrad Dybcio Cc: Luca Weiss , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , Konrad Dybcio , Matti =?iso-8859-1?Q?Lehtim=E4ki?= , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 04/13] remoteproc: qcom_q6v5_mss: Handle platforms with one power domain Message-ID: References: <20250127-msm8226-modem-v3-0-67e968787eef@lucaweiss.eu> <20250127-msm8226-modem-v3-4-67e968787eef@lucaweiss.eu> <5b0f9cd4-df65-4963-8d6d-5bdf759ba0c5@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5b0f9cd4-df65-4963-8d6d-5bdf759ba0c5@oss.qualcomm.com> On Tue, Jan 28, 2025 at 11:45:51AM +0100, Konrad Dybcio wrote: > On 27.01.2025 11:45 PM, Luca Weiss wrote: > > For example MSM8974 has mx voltage rail exposed as regulator and only cx > > voltage rail is exposed as power domain. This power domain (cx) is > > attached internally in power domain and cannot be attached in this driver. > > > > Fixes: 8750cf392394 ("remoteproc: qcom_q6v5_mss: Allow replacing regulators with power domains") > > Co-developed-by: Matti Lehtimäki > > Signed-off-by: Matti Lehtimäki > > Signed-off-by: Luca Weiss > > --- > > drivers/remoteproc/qcom_q6v5_mss.c | 20 +++++++++++++++++--- > > 1 file changed, 17 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c > > index e78bd986dc3f256effce4470222c0a5faeea86ec..0e1b0934ceedd13d5790b798afc95d68a8314c75 100644 > > --- a/drivers/remoteproc/qcom_q6v5_mss.c > > +++ b/drivers/remoteproc/qcom_q6v5_mss.c > > @@ -1831,6 +1831,13 @@ static int q6v5_pds_attach(struct device *dev, struct device **devs, > > while (pd_names[num_pds]) > > num_pds++; > > > > + /* Handle single power domain */ > > + if (num_pds == 1 && dev->pm_domain) { > > + devs[0] = dev; > > + pm_runtime_enable(dev); > > This call can fail > It returns void though? :D void pm_runtime_enable(struct device *dev); Stephan