From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1AB0190665 for ; Wed, 29 Jan 2025 08:17:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738138637; cv=none; b=f6QIMfEOdS6WqoHd99owhLAqmNhNhAfQRU5Psx78BSVFu3N1VRpkHrZiEA1W/KIoe1keiKmGJ5qA6oZCaK0zx/Mu6Orpg+88wgYPkPl9qmDuX1DNvQE6RXT+NM86tICD6dPwZgEnkrMb4XYk5bn8xqZpsVv+Y0Cm+je+myRIDAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738138637; c=relaxed/simple; bh=pr1H+qOgtFwlwxokFPKqAcNjsp+sUyK9zu3FmkZcpp4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GgCcPSphmAFCSET7k9oVwbl3/d+Fh08sbDgl9pi9wHJq1x6qaBX2wVAEoDLDZJGaptDT7W+eV9d6NbzZaSFX951Prq3asw5AG95MMkbTizV7sn2Gj5UCWvBkYzrDx/c8m6B9Y+Uf1z1KtUp3m7uZ0F7cxJfKr6/JUg/TOTHCmqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HBkaxvLB; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HBkaxvLB" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-38a34e8410bso3280607f8f.2 for ; Wed, 29 Jan 2025 00:17:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738138633; x=1738743433; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=w/+D0OekWy0GxppkPj3fPY5hpDHIrRe8OroWwhzjF34=; b=HBkaxvLBJhMmCK3yUgCz3m/QDVXTid8Uy2V8IfwlzGeweJWVgITLHkQONXC6IsGcp1 2BwOrb0ECzoqkZoAtcspSuNrDvSMZn/WvE4Kf0K5wXwr52hMdtZnzuIcSfwKa1+F3ywQ a8mgtoW3mrs0mXywpeWVNxnwFV+w0KB9liW6wNXusDw7gqxvY7CZ7fr6rhFw4d0i/5Z1 Vo33bz1TVX7FcBBLb95Dd0HUky6tzy6eUU3CDPnmO8Boju/LBrVtO1Z0yilyxSrO7yfx uo8o1NlExBLObaOV6SWt0zRbnDYcehD+UgaWdEwXVm4zzf30GZIpJouYpkp7vIef8Xen iP6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738138633; x=1738743433; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w/+D0OekWy0GxppkPj3fPY5hpDHIrRe8OroWwhzjF34=; b=sPBZrv2wS+FpP9aDNGxRL9/binwNZQtRuEtpMDvARL9CVyLSiRCIxjn+oyyNf3KbC6 M2ZlhnGh50T3XVS6K0L5jP38viEwvxiSM+Z/Nvbu06Mix1U33O8pHxkxa1py65eEE64r aSV0MAVddDEaRuOUPoR/4PRM5DUlheWb92pWOg88rcwBc/wLytAAjkG2eBXNsD1I2SpF AXZMzn93+ne05+dAW7e+TIVBCratyB8yuazMHgi4q+bwArmQZsYyeqz6ZopCKGdn8z30 RFloMzxAFyGkmbNTs6t8oUQlsfHQfVMA+JLPQxMZhLIWdP203gbP5UP206B86lEcA1lU ssPQ== X-Forwarded-Encrypted: i=1; AJvYcCVJJqRHAsqps3iVWFq23fLfD3Sp370WgbKTaYI8yiGrF621vRXpkRW8FygahZNRr2fupAxB6gUB0ue/yyFR@vger.kernel.org X-Gm-Message-State: AOJu0Yxd3ioD9ttWwPKtwAxSUEwC+LAjs+yaXTV3QyoU96DmKxXV/5ga l4PrvsPPnn1oiG0gDAY7afTS/J+Fg7el+PJzHM4IHes1rpXjc0U+aEvy2ypegko= X-Gm-Gg: ASbGncueDoz7eUH+jBPA1B88PDb4I7tUZdkqWyAS3PofHAunlJcfzzcN+m1N3mW+xT8 wHgqBrc+F7p/kZqbiu9bKROQikzXEiEN+DBkO6A4wuEn3MCQ0stRcq9AhfKThs0tXJSlk2v3mDT urnhyPjP3WrrHTfqu7gOAhx22bcEITfgvORkHBE3iKsyFIVW3rlbJEz4sB0OUapmu7JMfC+5to5 1Vsr3zSTurfsQXof1cocfilwMB3CRbVur+OIbcWLOjQEfqW79OtNE4t9ygcP6IFGKoPryMI1Jth DIxaE6hP1KhPZ01tjiZbyw== X-Google-Smtp-Source: AGHT+IHpJGqcr8Tk2T0wQuKtYNeP2wWRWN3r3xQi/6+WJha95RSeRs0NLgQ4Lr414eJF3CjQLmMLnw== X-Received: by 2002:adf:fa8a:0:b0:385:e1eb:a7af with SMTP id ffacd0b85a97d-38c520be00dmr1356231f8f.48.1738138632801; Wed, 29 Jan 2025 00:17:12 -0800 (PST) Received: from linaro.org ([77.64.147.194]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438dcc24d51sm13637275e9.14.2025.01.29.00.17.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2025 00:17:12 -0800 (PST) Date: Wed, 29 Jan 2025 09:17:05 +0100 From: Stephan Gerhold To: Luca Weiss Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Bjorn Andersson , Mathieu Poirier , Sibi Sankar , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] remoteproc: qcom_q6v5_pas: Use resource with CX PD for MSM8226 Message-ID: References: <20250128-pas-singlepd-v1-0-85d9ae4b0093@lucaweiss.eu> <20250128-pas-singlepd-v1-1-85d9ae4b0093@lucaweiss.eu> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250128-pas-singlepd-v1-1-85d9ae4b0093@lucaweiss.eu> On Tue, Jan 28, 2025 at 10:53:59PM +0100, Luca Weiss wrote: > MSM8226 requires the CX power domain, so use the msm8996_adsp_resource > which has cx under proxy_pd_names and is otherwise equivalent. > > Suggested-by: Stephan Gerhold > Fixes: fb4f07cc9399 ("remoteproc: qcom: pas: Add MSM8226 ADSP support") > Signed-off-by: Luca Weiss Not sure if Reviewed-by makes sense if I already did Suggested-by, but anyway: Reviewed-by: Stephan Gerhold > --- > drivers/remoteproc/qcom_q6v5_pas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c > index 88e7b84f223c0222a01e2a246a848f2889ac00b3..aca44bb6522f00cb525c4b816040445287444434 100644 > --- a/drivers/remoteproc/qcom_q6v5_pas.c > +++ b/drivers/remoteproc/qcom_q6v5_pas.c > @@ -1319,7 +1319,7 @@ static const struct adsp_data sm8650_mpss_resource = { > }; > > static const struct of_device_id adsp_of_match[] = { > - { .compatible = "qcom,msm8226-adsp-pil", .data = &adsp_resource_init}, > + { .compatible = "qcom,msm8226-adsp-pil", .data = &msm8996_adsp_resource}, > { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource}, > { .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init}, > { .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource}, > > -- > 2.48.1 >