From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D13471A238D; Thu, 6 Mar 2025 08:17:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741249079; cv=none; b=LChvnv5SmpExIX0E0uXGN7YSk9e8tYFUqZW/XqyN6z0f853Z7z6YG0RSzPw06QrBBuVpBjdtlpjAfKfjXaDjCJQ7xoOgvqQqRkygRbepWtofu6TeV8ZFV1cVtQeNcEFaGopRI5j+THlFOo3b93Z1mBH0RfKBN0KLMst1FMIYu/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741249079; c=relaxed/simple; bh=lXk0XH2YJ1Cojq/25A0cKMl1JwYrbN7gvvwsFr9LoWw=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XXHyyhanYoG+LFdXQJyE4wxzQMJhRwW0CibK5hALJGvkzcTSZS5cv2du32pVMgE+CvDQjqbkc8k4VQn9bzwualYZOVe2wvlEzPNk1/6RDx3ctSSKjQ3mLkcyUYr+/KGPhFi0UM1AnUDsgQeUHX6TopjzKQ7UbnUS09iFyXD341U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=VmZbOQpa; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="VmZbOQpa" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 525LGbZe020153; Thu, 6 Mar 2025 08:17:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pkIsVhDztLqIp+rD/dHwzy74oOWmICKQF6M4GRUOyxc=; b=VmZbOQpa0BZ74fF9 i0vWrKBkMTF12qcTn8JyMmSOvsN5BeUupe2jPlFrLnCwLLRhADqw5PjKscTXyXzC DEiIp2+t1UtL3NgJ/0Xfudehe3MthzbLjxxIJrD8EDNsYI/eyEvp0cVuZVRGjkwB 7rKz+vEQ8uYVL9oSTdmljWO7UsXe9cGBFyZbJLabhhmRCVKKLH71Dd9C6W4D4viw Pj2mtAtDSS7+zfLYbQHorSfArJ0rSzHOP6Lp0Gj4HE6XIhYLWI2OlWSzK+PkeaD6 g7snb2nv5K9dJ4nQZc0lOPrDD8Rf69b4IN9189RHe8aX/rP/+KTfIFf4azshieDY kkYldA== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 456xcuhe8y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Mar 2025 08:17:47 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 5268HYsd027881 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Mar 2025 08:17:34 GMT Received: from hu-wasimn-hyd.qualcomm.com (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 6 Mar 2025 00:17:26 -0800 Date: Thu, 6 Mar 2025 13:47:15 +0530 From: Wasim Nazir To: Krzysztof Kozlowski CC: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Subject: Re: [PATCH v5 5/6] arm64: dts: qcom: Add support for QCS9075 Ride & Ride-r3 Message-ID: References: <37isla6xfjeofsmfvb6ertnqe6ufyu3wh3duqsyp765ivdueex@nlzqyqgnocib> <67b888fb-2207-4da5-b52e-ce84a53ae1f9@kernel.org> <80e59b3b-2160-4e24-93f2-ab183a7cbc74@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 7kEkqM_imddBGCFbBu-oHWq80mxMPMYf X-Proofpoint-GUID: 7kEkqM_imddBGCFbBu-oHWq80mxMPMYf X-Authority-Analysis: v=2.4 cv=eeXHf6EH c=1 sm=1 tr=0 ts=67c95a2b cx=c_pps a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=5B4Ghw-gXjSuLfDcNkQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-06_03,2025-03-06_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=886 mlxscore=0 impostorscore=0 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503060062 On Mon, Mar 03, 2025 at 08:46:55AM +0100, Krzysztof Kozlowski wrote: > On 27/02/2025 08:37, Wasim Nazir wrote: > > On Wed, Jan 15, 2025 at 09:35:34AM +0100, Krzysztof Kozlowski wrote: > >> On 15/01/2025 06:48, Wasim Nazir wrote: > >>>> The the SoC, I am asking about the board. Why each of them is for > >>>> example r3? > >>>> > >>>> So this is not sufficient explanation, nothing about the board, and > >>>> again just look Renesas and NXP. > >>>> > >>> > >>> Hi Krzysztof, > >>> > >>> sa8775p(AUTO), qcs9100(IOT), qcs9075(IOT) are different SoCs based on > >>> safety capabilities and memory map, serving different purpose. > >>> Ride & Ride-r3 are different boards based on ethernet capabilities and > >>> are compatible with all the SoCs mentioned. > >> > > > > Hi Krzysztof, > > > >> Compatible? What does it mean for a board? > >> > > > > Ride board is based on multiple daughter cards (SOC-card, display, > > camera, ethernet, pcie, sensor, etc.). > > > > The SOC is not directly soldered to Ride board, instead SOC is soldered > > on SIP (System in Package) card which can be mounted on SOC-daughter card of > > Ride board. > > - SoC => SIP-card => SOC-daughter-card (Ride) > > > So basically pretty like other designs using SoM. > > > > > Together with SIP cards and other daughter cards we are creating different > > -Ride Variants with differences in memory map & thermal mitigations. > > > > The SIP card consists of SOC, PMIC & DDR and it is pin compatible to the > > SOC daughter card of -Ride board. Only SOC is changing accross SIP > > cards, except an additional third party SIL-PMIC for SAIL, which is not > > present in QCS9075 Ride. > > Just like every SoM > > > > > Other daughter cards remains same for -Ride variants, except > > ethernet card which is different for -Ride rev3 variants. > > > > So the Ride board (combination of daughter cards) is same across the SIP, > > while SOC on SIP card is changing which can be sa8775p, qcs9100 or qcs9075. > > > >> Third time: did you look how other vendors do it? > >> > > > > Yes, we have reviewed other vendors. However, please feel free to share > > any specific reference you would like us to follow. > > > > Here are few reference files we found from other vendors where similar > > tasks are performed which includes code refactoring and HW modularity: > > - Freescale: fsl-ls208xa.dtsi, fsl-ls2088a.dtsi, fsl-ls2081a-rdb.dts > > That's an unexpected choice - I would rather look at dozen of SoMs for > iMX platforms. > > > - Renesas: white-hawk-common.dtsi, r8a779g0-white-hawk.dts > > - Rockchip: px30-engicam-common.dtsi, px30-engicam-ctouch2.dtsi, > > px30-engicam-px30-core-ctouch2.dts > > > > In our case along with describing the HW, code refactoring is also done > > which might be causing confusion, but we are ready for any inputs for > > correction. > > I don't understand why this was not properly described since beginning. > You had the hardware in your hands and went with incomplete or even > incorrect hardware description. > > > > > Putting this pictorial diagram for updated DT structure depicting our HW. > > - qcs9xxx-module.dtsi specifying QCS9xxx based SIP card/module having > > SoC, PMICs, Memory-map updates. > > - qcom-ride-common.dtsi specifying ride daughter boards, here we are > > doing code refactoring also as this is common for all ride boards. > > - qcom-ride-ethernet-aqr115c.dtso specifying ethernet overlay board which > > uses 2.5G phy and can be overlayed to ride boards to get ride-r3. > > By default ride uses 1G phy. > > - qcs9075-iq-9075-evk.dts is the new name for RB8 as per new product > > name. We will be changing this in next patch series. > > > > +-----------------------------------------------------------------------------------------------------------------------------------------------+ > > | | > > | sa8775p.dtsi | > > | | | > > | +-------------------------+-----------------------+ | > > | | | | | > > | v | v | > > | qcs9075-module.dtsi | qcs9100-module.dtsi | > > So this is the SoM? Yes this is SoM. > > > | | | | | > > | v v v | > > | (IOT) (AUTO) (IOT) | > > | | | | | > > | +----------------------+ | | | > > | | | | | | > > | | | +-------------------------+-----------------------+-------------------< qcom-ride-common.dtsi | > > Which piece of actual hardware is represented in qcom-ride-common? > All daughter cards like SOC-card, display, camera, ethernet, pcie, sensor, etc. > > | | | | | | | | | > > | v v v v v v v | > > | qcs9075-iq-9075-evk.dts qcs9075-ride.dts sa8775p-ride.dts qcs9100-ride.dts | > > | | | | | > > | | +-------------------------+-----------------------+-------------------< qcom-ride-ethernet-aqr115c.dtso | > > | | | | | | | | > > | v v v v v v | > > | qcs9075-ride-r3.dts sa8775p-ride-r3.dts qcs9100-ride-r3.dts | > > I think I gave already few times that answer: No. You cannot reference > from a module.c another .c file. You cannot reference DTS from DTS. > > Strictly speaking you can, of course, but you must not. That's not how > source code is done to be manageable and readable. Ah the arrow is leading to confusion. Actually we are not including dts here instead *.dtso file will be overlayed to *-ride.dts to generate *-ride-r3.dts. Below is the correct arrow sequence. | qcs9075-iq-9075-evk.dts qcs9075-ride.dts sa8775p-ride.dts qcs9100-ride.dts | | | | | | | +-------------------------+-----------------------+---------------------< qcom-ride-ethernet-aqr115c.dtso | | | | | | | v v v | | qcs9075-ride-r3.dts sa8775p-ride-r3.dts qcs9100-ride-r3.dts | > > > | | > > +-----------------------------------------------------------------------------------------------------------------------------------------------+ > > > >>> > >>> With the combination of these 3 SoCs and 2 boards, we have 6 platforms, > >>> all of which we need. > >>> - sa8775p-ride.dts is auto grade Ride platform with safety feature. > >>> - qcs9100-ride.dts is IOT grade Ride platform with safety feature. > >>> - qcs9075-ride.dts is IOT grade Ride platform without safety feature. > >>> > >>> Since the Ride-r3 boards are essentially Ride boards with Ethernet > >>> modifications, we can convert the Ride-r3 DTS to overlays. > >> How one board can be with multiple SoCs? If it is soldered, it's close > >> to impossible - that's just not the same board. If it is not soldered, > >> why you are not explaining it? What is Ride board? What is there? What > >> can go there? How it can be used in other SoCs? Or for which SoCs? Is > >> there a datasheet available? > >> > > > > As our SoC is based on SIP card and SIP card is compatible with Ride > > board, we could able to use same Ride board (which is combination of > > multiple daughter cards) with multiple SIP cards. > > These SIP cards can be of sa8775p, qcs9100 or qcs9075 SOC. > > Describe properly the hardware - if you have a module or SIP if you > decide not to use industry-standard naming (but why...), then describe > it in DTSI. We refer to it as ‘module’ in our datasheet, so I use the same term here. Thanks for pointing it out; we can proceed with the SoM name. Below is the updated diagram: +-----------------------------------------------------------------------------------------------------------------------------------------------+ | | | sa8775p.dtsi | | | | | +-------------------------+-----------------------+ | | | | | | | v | v | | qcs9075-som.dtsi | qcs9100-som.dtsi | | | | | | | v v v | | (IOT) (AUTO) (IOT) | | | | | | | +----------------------+ | | | | | | | | | | | | +-------------------------+-----------------------+-------------------< qcom-ride-common.dtsi | | | | | | | | | | | v v v v v v v | | qcs9075-iq-9075-evk.dts qcs9075-ride.dts sa8775p-ride.dts qcs9100-ride.dts | | | | | | | +-------------------------+-----------------------+---------------------< qcom-ride-ethernet-aqr115c.dtso | | | | | | | v v v | | qcs9075-ride-r3.dts sa8775p-ride-r3.dts qcs9100-ride-r3.dts | | | +-----------------------------------------------------------------------------------------------------------------------------------------------+ > > Best regards, > Krzysztof Thanks & regards, Wasim