From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C738F219E86 for ; Fri, 7 Mar 2025 13:30:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741354204; cv=none; b=BGnUzZNpvoedPbeet+2JQRXC7a+JNuSbpxrW9S0L9nJ+DeLF8685HQNFF7CrNARRuM6W11VzDl0XA3K7g9iiXuJIoRsQ3CUTB9srRqwpgCN664rC+PkGRwGyMmW83c+4keyl6n0JBFxBjB21Av575VvNlgFZ0nh5LK3YNYL3FBI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741354204; c=relaxed/simple; bh=wZwZ4u+3MacWP7ZiA/RT20bOi492x2WChjuClM+KD/k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aVXS1kDL/EXNRhuqp8+xvwpznCt4l23NtrWkMW0iv9KHZSarq/P1Q9MBnFaiT2QJ03D2gd1n44u2GepFQwBlXVeaN+Z4LVbIBdGeULX3H4VdGYDNaTjCMhc68rFQW2IemHkzvXgs7GUfGYJrb3q5kuT89XDaIsNeNHsqQ8EpEPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch; spf=none smtp.mailfrom=ffwll.ch; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b=ltLNyqRI; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="ltLNyqRI" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3910e101d0fso1018967f8f.2 for ; Fri, 07 Mar 2025 05:30:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1741354200; x=1741959000; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=ekE5xsi6ZfzsstIFHcXwKSB/c+BLxZ8NF8WHZmG2dto=; b=ltLNyqRIWqfjVh6pXpsfxrx8XRlc+M1AXDVMRP5muKyhiqvAdYlZ0xcUI9Enjsi9PY XcDtjXDwquuPlqJHUNaAIH6HtJwhPMt2zsLGt3AeNBy0YdemZTJGz00gUA19y4roKgdd n5pCuq06eyoaXtGVVdwj5YEJLefECvWEcRB9k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741354200; x=1741959000; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ekE5xsi6ZfzsstIFHcXwKSB/c+BLxZ8NF8WHZmG2dto=; b=t+r/G4o5Mro0HD3y+0CdXz/Ghbe/XRg5Y6qcg5XwUHCjjFE/7UUDVZM1bnjZRVHjQ2 9rXiOZS/iCfL1pNzIsBV5o67ldD5oKvo35Mau4bUmoQi405dauceHIYZidg+/hDen1XA QtHbVGEh9twMaSkgiE1B+cWiiEDnaFFh8Bi6bhXu030XUssfoEB3TAwYygYJilr28EAl mHcShyJv934aNojLEQzwCZOEjVXxoPeQAMsCzbaZf4y4lXsUloq3cyQyO4rSPJ0CBOKQ uAy8Zn+hO/gpNEN4GHm7ZQm9aZTCIXzjCrNTJv82jInpuyyS43bC1IpBgSfQNWRGmQEj T6hg== X-Forwarded-Encrypted: i=1; AJvYcCXkVTH3pI3RLFlEKNPMLtKqlvQcmK78rKAzCHIKPYpEns54qmW4DLHs9kpvKkir8zuXUoO5dnDrE7938d38@vger.kernel.org X-Gm-Message-State: AOJu0YwFeek8RBZMUsW7MfcSUb8Bae4F//eybDageSzwfDnM4ZNEOWIj rdzM0In3MCwDLPgdPzM+DetqqHksJg/6sDVQReBxxET9kbh5Hg75h1vS+T6c64I= X-Gm-Gg: ASbGncv1wjLvLolR2OeX+PXLfuySKjK/aXaRlD+CG0Wd0wnxZPQXmH5YyQggpvTSgwl iZNTtyHIbJ5FGBCeOkUl7tPZKb7Q5W2I4KY+uSr2tyLta7E3RDrGod8qC4gtBPWwuBk/+PWHKmN IaEvMILJWXINnNw6GAi7giteGDGPyh+3TqQxtpWINP0lJI1RbRlToG6viKIQZyCvOaxf8mEKq7p 8BA9cKrCLxSsKuyxG9Uni6rqTBtsebJHj4JMX6/f/qwxninKdH6xGwAk+Rfx4DCFTqixZGB0Fub kh3Eb8CUrciena0wOqIIbnrPVE8ZCIicA2nT5yW2gCMF9tpzUf8JjP05 X-Google-Smtp-Source: AGHT+IH/kkCP3WG8+wzNo7ysyBh/OLARokHFUAgPdG9FvCx5V4btdPhz7YMsZxr6IpgW9UUP3aP3IA== X-Received: by 2002:a05:6000:144d:b0:38f:3a89:fdb5 with SMTP id ffacd0b85a97d-39132d244fdmr2005477f8f.11.1741354199959; Fri, 07 Mar 2025 05:29:59 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:5485:d4b2:c087:b497]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bdd8b0425sm51891245e9.3.2025.03.07.05.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Mar 2025 05:29:59 -0800 (PST) Date: Fri, 7 Mar 2025 14:29:57 +0100 From: Simona Vetter To: Dmitry Baryshkov Cc: Lyude Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Jani Nikula , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Jani Nikula Subject: Re: [PATCH RFC v3 0/7] drm/display: dp: add new DPCD access functions Message-ID: Mail-Followup-To: Dmitry Baryshkov , Lyude Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Jani Nikula , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Jani Nikula References: <20250307-drm-rework-dpcd-access-v3-0-9044a3a868ee@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250307-drm-rework-dpcd-access-v3-0-9044a3a868ee@linaro.org> X-Operating-System: Linux phenom 6.12.11-amd64 On Fri, Mar 07, 2025 at 06:34:42AM +0200, Dmitry Baryshkov wrote: > Existing DPCD access functions return an error code or the number of > bytes being read / write in case of partial access. However a lot of > drivers either (incorrectly) ignore partial access or mishandle error > codes. In other cases this results in a boilerplate code which compares > returned value with the size. > > As suggested by Jani implement new set of DPCD access helpers, which > ignore partial access, always return 0 or an error code. Implement > new helpers using existing functions to ensure backwards compatibility > and to assess necessity to handle incomplete reads on a global scale. > Currently only one possible place has been identified, dp-aux-dev, which > needs to handle possible holes in DPCD. > > This series targets only the DRM helpers code. If the approach is found > to be acceptable, each of the drivers should be converted on its own. > > Signed-off-by: Dmitry Baryshkov Just wanted to drop my "I like this" on your series here. Short read/writes come from unix pipes, and they're everywhere, and yes ime everyone gets them wrong. So ack or whatever that means :-) -Sima > --- > Changes in v3: > - Fixed cover letter (Jani) > - Added intel-gfx and intel-xe to get the series CI-tested (Jani) > - Link to v2: https://lore.kernel.org/r/20250301-drm-rework-dpcd-access-v2-0-4d92602fc7cd@linaro.org > > Changes in v2: > - Reimplemented new helpers using old ones (Lyude) > - Reworked the drm_dp_dpcd_read_link_status() patch (Lyude) > - Dropped the dp-aux-dev patch (Jani) > - Link to v1: https://lore.kernel.org/r/20250117-drm-rework-dpcd-access-v1-0-7fc020e04dbc@linaro.org > > --- > Dmitry Baryshkov (7): > drm/display: dp: implement new access helpers > drm/display: dp: change drm_dp_dpcd_read_link_status() return value > drm/display: dp: use new DCPD access helpers > drm/display: dp-aux-dev: use new DCPD access helpers > drm/display: dp-cec: use new DCPD access helpers > drm/display: dp-mst-topology: use new DCPD access helpers > drm/display: dp-tunnel: use new DCPD access helpers > > drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 8 +- > .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 2 +- > drivers/gpu/drm/display/drm_dp_aux_dev.c | 12 +- > drivers/gpu/drm/display/drm_dp_cec.c | 37 ++- > drivers/gpu/drm/display/drm_dp_helper.c | 307 +++++++++------------ > drivers/gpu/drm/display/drm_dp_mst_topology.c | 105 ++++--- > drivers/gpu/drm/display/drm_dp_tunnel.c | 20 +- > drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.c | 4 +- > drivers/gpu/drm/msm/dp/dp_ctrl.c | 24 +- > drivers/gpu/drm/msm/dp/dp_link.c | 18 +- > drivers/gpu/drm/radeon/atombios_dp.c | 8 +- > include/drm/display/drm_dp_helper.h | 92 +++++- > 12 files changed, 322 insertions(+), 315 deletions(-) > --- > base-commit: 565351ae7e0cee80e9b5ed84452a5b13644ffc4d > change-id: 20241231-drm-rework-dpcd-access-b0fc2e47d613 > > Best regards, > -- > Dmitry Baryshkov > -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch