From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BE62C6FD1C for ; Fri, 24 Mar 2023 07:56:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230259AbjCXH4Y (ORCPT ); Fri, 24 Mar 2023 03:56:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230075AbjCXH4X (ORCPT ); Fri, 24 Mar 2023 03:56:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5655F227B1 for ; Fri, 24 Mar 2023 00:56:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E63A66299C for ; Fri, 24 Mar 2023 07:56:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4462FC4339B; Fri, 24 Mar 2023 07:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679644582; bh=tcdb3u+oQALvYdJlagydXkPjVB03z6C85ADaml3ST8I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m5igMPXYXHC2nSRf+F6n16wn7hX5i1U5ozQaEXJH8wuwGu4fF4zjsJuRyqcjiW6o2 P0p0l8ZRSafBHeGpnGCR/u5+PRXauQRBLCA6R7witG6FqL4O7sKdZqSXpZhzkFrGGp zhNht5KvVw0wOBuVS5xYbD6V2Een8dDfMQoJb1WqxMvleDjm0XFCjxUCugDaRW6ENN qOj4huijsCOuSfCSE2+WIcA0t6j5OWt1D25XKaNkBgMT8g+FuJ4FG0rbofL0QJx4DL iBzb75XUCibMSTYdZ6IQFU1V5Xu6oNYyEL7Tznk2O33gAT4kwN4Cm+IRqcIq1StVgK ttykZVs8RdsEw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pfcHd-0003CJ-FZ; Fri, 24 Mar 2023 08:56:21 +0100 Date: Fri, 24 Mar 2023 08:56:21 +0100 From: Johan Hovold To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, Johan Hovold Subject: Re: [PATCH 03/41] dt-bindings: phy: migrate QMP UFS PHY bindings to qcom,sc8280xp-qmp-ufs-phy.yaml Message-ID: References: <20230324022514.1800382-1-dmitry.baryshkov@linaro.org> <20230324022514.1800382-4-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230324022514.1800382-4-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Mar 24, 2023 at 05:24:36AM +0300, Dmitry Baryshkov wrote: > Migrate legacy bindings (described in qcom,msm8996-qmp-ufs-phy.yaml) > to qcom,sc8280xp-qmp-ufs-phy.yaml. This removes a need to declare > the child PHY node or split resource regions. > > Signed-off-by: Dmitry Baryshkov > --- > .../phy/qcom,msm8996-qmp-ufs-phy.yaml | 244 ------------------ > .../phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 94 ++++++- > 2 files changed, 89 insertions(+), 249 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-ufs-phy.yaml > examples: > @@ -84,5 +150,23 @@ examples: > vdda-phy-supply = <&vreg_l6b>; > vdda-pll-supply = <&vreg_l3b>; > > + #phy-cells = <0>; > + }; > + - | > + #include > + > + phy@1d87000 { > + compatible = "qcom,sm8250-qmp-ufs-phy"; > + reg = <0x01d87000 0x1c0>; > + > + clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; > + clock-names = "ref", "ref_aux"; > + > + resets = <&ufs_mem_hc 0>; > + reset-names = "ufsphy"; > + > + vdda-phy-supply = <&vreg_l6b>; > + vdda-pll-supply = <&vreg_l3b>; > + > #phy-cells = <0>; > }; This example also looks unnecessary. Johan