Re: [PATCH v4 18/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for usb_1_qmpphy

Konrad Dybcio
2023-03-18T13:11:37Z

On 18.03.2023 13:18, Bryan O'Donoghue wrote:
> Switch on USB orientation-switching for usb_1_qmp via TCPM. Detecting the
> orientation switch is required to get the PHY to reset and bring-up the PHY
> with the CC lines set to the appropriate lane.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> index 43d549d6672e9..e5eecf02653ff 100644
> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> @@ -1295,6 +1295,12 @@ &usb_1_qmpphy {
>
> vdda-phy-supply = <&vreg_l9a_1p2>;
> vdda-pll-supply = <&vreg_l18a_0p92>;
> + orientation-switch;
I think this property could be put in the SoC DTSI, the hardware
does support roleswitching

Add a newline before the subnode, please.

Konrad
> + port {
> + qmp_ss_mux: endpoint {
> + remote-endpoint = <&pmic_tcpm_ss_mux>;
> + };
> + };
> };
>
> &usb_2 {
> @@ -1379,5 +1385,17 @@ connector {
> PDO_FIXED_DUAL_ROLE |
> PDO_FIXED_USB_COMM |
> PDO_FIXED_DATA_SWAP)>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + pmic_tcpm_ss_mux: endpoint {
> + remote-endpoint = <&qmp_ss_mux>;
> + };
> + };
> + };
> };
> };