Re: [PATCH v4 04/18] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add port as an optional

Rob Herring
2023-03-21T20:49:40Z

On Sun, Mar 19, 2023 at 12:45:13PM +0100, Krzysztof Kozlowski wrote:
> On 18/03/2023 13:18, Bryan O'Donoghue wrote:
> > port is required to instantiate a remote-endpoint which can receive
> > orientation-switch messages from a Type-C mux.
> >
> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> > ---
> > .../bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml
> > index 52886cdb0e506..1c887e34b1223 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml
> > @@ -65,6 +65,12 @@ properties:
> > description: Flag the port as possible handler of orientation switching
> > type: boolean
> >
> > + port:
> > + $ref: /schemas/graph.yaml#/properties/port
> > + description:
> > + A port node to link the PHY to a TypeC controller for the purpose of
> > + handling altmode muxing and orientation switching.
>
> Please extend the example as well.
>
> Don't you have there two ports? USB and DP?

Or 3: USB, DP, and connector.

Please make sure this all aligns with what Bjorn and I discussed
recently. It was for glink specifically.

Rob