From: Christoph Hellwig <hch@infradead.org>
To: Sarthak Garg <quic_sartgarg@quicinc.com>
Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, quic_rampraka@quicinc.com,
quic_bhaskarv@quicinc.com, quic_sachgupt@quicinc.com,
quic_pragalla@quicinc.com, quic_sayalil@quicinc.com,
Brian Norris <briannorris@chromium.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH V1 1/2] mmc: core: Define new vendor ops to enable internal features
Date: Mon, 3 Apr 2023 22:13:30 -0700 [thread overview]
Message-ID: <ZCux+gsR8Nz4Epxw@infradead.org> (raw)
In-Reply-To: <20230401165723.19762-2-quic_sartgarg@quicinc.com>
On Sat, Apr 01, 2023 at 10:27:22PM +0530, Sarthak Garg wrote:
> Define new ops to let vendor enable internal features in
> mmc_suspend/resume paths like partial init feature.
1) vendors have absolutely no business doing anything, you might be
doing either something entirely wrong or use the wrong terminology
here.
2) any kind of core hook not only needs a very good description, but
also an actual user that goes along in the same series.
next prev parent reply other threads:[~2023-04-04 5:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 16:57 [PATCH V1 0/2] Introduce new vendor op and export few symbols Sarthak Garg
2023-04-01 16:57 ` [PATCH V1 1/2] mmc: core: Define new vendor ops to enable internal features Sarthak Garg
2023-04-02 12:48 ` Linus Walleij
2023-04-14 5:29 ` Sarthak Garg (QUIC)
2023-04-04 5:13 ` Christoph Hellwig [this message]
2023-04-14 5:33 ` Sarthak Garg (QUIC)
2023-04-14 5:36 ` Christoph Hellwig
2023-04-14 6:52 ` Sarthak Garg (QUIC)
2023-04-14 13:15 ` Christoph Hellwig
2023-05-11 5:00 ` Sarthak Garg (QUIC)
2023-04-01 16:57 ` [PATCH V1 2/2] mmc: core: Export core functions to let vendors use for their features Sarthak Garg
2023-04-01 20:50 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCux+gsR8Nz4Epxw@infradead.org \
--to=hch@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=briannorris@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_pragalla@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_sachgupt@quicinc.com \
--cc=quic_sartgarg@quicinc.com \
--cc=quic_sayalil@quicinc.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox