Re: [PATCH v8 1/9] dt-bindings: usb: qcom,dwc3: Add bindings for SC8280 Multiport

Krishna Kurapati PSSNV
2023-05-17T11:11:01Z

On 5/16/2023 4:29 PM, Johan Hovold wrote:
> On Sun, May 14, 2023 at 11:19:09AM +0530, Krishna Kurapati wrote:
>> Add the compatible string for SC8280 Multiport USB controller from
>> Qualcomm.
>>
>> There are 4 power event irq interrupts supported by this controller
>> (one for each port of multiport). Added all the 4 as non-optional
>> interrupts for SC8280XP-MP
>>
>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>> ---
>> .../devicetree/bindings/usb/qcom,dwc3.yaml | 22 +++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sc8280xp-dwc3-mp
>> + then:
>> + properties:
>> + interrupts:
>> + maxItems: 7
>> + interrupt-names:
>> + items:
>> + - const: dp_hs_phy_irq
>> + - const: dm_hs_phy_irq
>> + - const: ss_phy_irq
>
> I assume that these are only for the first port, and that you need to
> define these interrupts also for ports 2-4.
>

Hi Johan,

I wanted to add them when wakeup-source is enabled but since you
mentioned that these must be added now and driver support can be added
later, I will make a patch separately for this in v9.

Hi Krzysztof,

Can I use the following notation for the new interrupts ?

dp_hs_port2_irq
dm_hs_port2_irq
dp_hs_port3_irq
dm_hs_port3_irq
dp_hs_port4_irq
dm_hs_port4_irq

That way the interrupt names for first port will be same as ones for
single port.

Wanted to clarify this before I make a formal patch.

Regards,
Krishna,