From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C2CC77B75 for ; Fri, 19 May 2023 06:12:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229531AbjESGMn (ORCPT ); Fri, 19 May 2023 02:12:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjESGMm (ORCPT ); Fri, 19 May 2023 02:12:42 -0400 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 347B11AC; Thu, 18 May 2023 23:12:41 -0700 (PDT) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-64d2e8a842cso433162b3a.3; Thu, 18 May 2023 23:12:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684476760; x=1687068760; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+4SN79Akj+b85DVae9qGC3BAR6GQduEBcnLj3YcjnHU=; b=Qsb3/9IqTkYzB+lUSxJ3cVvE7+1MtyMYPtChMAICXWgpxGqT+vots9SpUmib8an714 CZJz52v24Gzp+BRDWKn3BM7tdT9D2EN/iD47wYLypxm39ptgwW4nFyFTV3jiH5lcKlHr rq+Ba+zrI0cqk0f5S5h+j8EXlYBrksIn467kc+T0ClnjpH5NoPDldgsFIRFiGCF9eiaH XvE24lXpVzmV6py7P5dFXzmdoQt4H+MlLITh5xUl1uOBbR8W+dhXHooALgqdPjnVZjZM 8XLn3WgE4BAJ4wetf/lCDVnNe0Fbl8y9+mzZsPuCeC3VqTeDIhkU60eWmLmGqI7qtsIw dzzg== X-Gm-Message-State: AC+VfDwxL3kxIHPp5tt9eEEi6SELX7qwDtJaTeJ4nOubsoZaEM2JWWCG gMag0pJ+/xy/WXJL5oe0Zkk= X-Google-Smtp-Source: ACHHUZ4ofhRJDj2vK6lAjY0g6mcB8/BlvmqrFVReEtZMOaB2HN6AWPaKGIiMWBSj5LRDoL1gK+4qgg== X-Received: by 2002:a05:6a00:804:b0:647:d698:56d2 with SMTP id m4-20020a056a00080400b00647d69856d2mr1842354pfk.27.1684476759789; Thu, 18 May 2023 23:12:39 -0700 (PDT) Received: from dev-linux.lan (cpe-70-95-21-110.san.res.rr.com. [70.95.21.110]) by smtp.gmail.com with ESMTPSA id f12-20020aa78b0c000000b0063b7f3250e9sm2283595pfd.7.2023.05.18.23.12.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 23:12:39 -0700 (PDT) Date: Thu, 18 May 2023 23:12:37 -0700 From: Sukrut Bellary To: Dan Carpenter Cc: Abel Vesa , Srinivas Kandagatla , Amol Maheshwari , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Shuah Khan Subject: Re: [PATCH] misc: fastrpc: Fix double free of 'buf' in error path Message-ID: References: <20230518100829.515143-1-sukrut.bellary@linux.com> <9194ebdf-f335-4cd6-bf89-bb4f86a57784@kili.mountain> <28c6814d-1863-41fa-a471-35a3ccf4447c@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <28c6814d-1863-41fa-a471-35a3ccf4447c@kili.mountain> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, May 19, 2023 at 07:16:14AM +0300, Dan Carpenter wrote: > On Thu, May 18, 2023 at 07:45:22PM -0700, Sukrut Bellary wrote: > > > > > > > > Reviewed-by: Shuah Khan > > > > Signed-off-by: Sukrut Bellary > > > > --- > > > ^^^ > > > Put testing caveats here instead, where it will be removed from the > > > git log. > > > > > > > Shall I add "This is based on static analysis only. Compilation tested" > > here > > or > > is it not required to mention this for all the fixes? > > Can you please recommend what's is the preferred method I need to follow? > > You can't go wrong with always adding it. The untested part is useful > to know. Also it's good to know how a bug is found so we can say if > it's affecting user and so we can improve our processes going forward. > Ok, that's clear. Thanks for the input. Regards, Sukrut Bellary > regards, > dan carpenter >