From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 709CAC7EE23 for ; Wed, 7 Jun 2023 15:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240212AbjFGPbA (ORCPT ); Wed, 7 Jun 2023 11:31:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240645AbjFGPa6 (ORCPT ); Wed, 7 Jun 2023 11:30:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 845CF1FE2 for ; Wed, 7 Jun 2023 08:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686151743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fxLtlaE05xIT9NZmGVGxp/EURIr6OC1Lp2hDELcXxAU=; b=hY4Hp0X7GMMX3ghASGj9u23WCsugZ6xTZgYozEzgK+Rli4pEImXlRJ3LsRaLPn3CDPdaZG KUWsVCEIJLJYrkWtGM5eyWPWeOZu3oReid1FXcLR819razB6wnZUNQuTlFfrlbwIMg16rg 536q//MOOT5ywv5PIenw0/9KGswZliM= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-347-GRZTzZyxNL-rJ3iEjMruCw-1; Wed, 07 Jun 2023 09:44:59 -0400 X-MC-Unique: GRZTzZyxNL-rJ3iEjMruCw-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-568ab5c813eso122736547b3.2 for ; Wed, 07 Jun 2023 06:44:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686145493; x=1688737493; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fxLtlaE05xIT9NZmGVGxp/EURIr6OC1Lp2hDELcXxAU=; b=QdNzuFta/sJvpo82yEJZo3mZ2XNnXv237tc+s6GzfuC5tD4Kr5ZxVsSzeAUMQSf8Zo 0qU6DLEL0OXqQc/NV8RiZQhWgIyBQ2vtx8fVLToqv371N8eDfY5Gyna8jeMX/y1w74/l OfhaBvbzpvy2QSRkvlvlU4JkmKVfAhzXNL1HbXkPewyrmlDJb/TJSxWDErI+0hfnUqwK QNqK8D2EkdTTrmbcazgh/zneoaxOcJ+j3nx2XSvZSrTz9RMN/AvQkHCJ+DLQIrsM8PnB e4llFkvTklvtdEH138fZkvcenok0HBNSk694EEnypE8cn6Sjy7kf69O8VV5JpozrOLO2 jiJA== X-Gm-Message-State: AC+VfDzIyUYtOCKO2vN/6DpdAYOv5lwpsBbpMptnJR6ejdBRFccNWYTr vewCgtmFOquOeoZNYTL0pk1B1bu+nNfCsWIbZ7S6C+xRo9r5xVRIeHIGPPy0TUcliFVaHqSbx+0 rEYx4n8A9V4JobC95Reu6tQvCAg== X-Received: by 2002:a0d:eb0b:0:b0:565:99c0:a690 with SMTP id u11-20020a0deb0b000000b0056599c0a690mr7226035ywe.36.1686145493487; Wed, 07 Jun 2023 06:44:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5wTaHqLBZp6jWJoe619kJAiY31OJl2xtPem1GubEkGBi48Y4e3G4HrsBbsiFfYL5yENCqRhw== X-Received: by 2002:a0d:eb0b:0:b0:565:99c0:a690 with SMTP id u11-20020a0deb0b000000b0056599c0a690mr7226006ywe.36.1686145493096; Wed, 07 Jun 2023 06:44:53 -0700 (PDT) Received: from brian-x1 (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id j203-20020a8192d4000000b00568cbb028c6sm1115953ywg.85.2023.06.07.06.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 06:44:52 -0700 (PDT) Date: Wed, 7 Jun 2023 09:44:50 -0400 From: Brian Masney To: Lucas Karpinski Cc: linux-kernel@vger.kernel.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, ahalaney@redhat.com, echanude@redhat.com, quic_shazhuss@quicinc.com Subject: Re: [PATCH] Revert "arm64: dts: qcom: sa8540p-ride: enable pcie2a node" Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Lucas, On Fri, Jun 02, 2023 at 03:33:21PM -0400, Lucas Karpinski wrote: > This reverts commit 2eb4cdcd5aba2db83f2111de1242721eeb659f71. I am all for reverting this commit however I think your commit message needs cleaned up. > The patch introduced a sporadic error where the Qdrive3 will fail to > boot occasionally due to an rcu preempt stall. > Qualcomm has disabled pcie2a downstream: > https://git.codelinaro.org/clo/la/platform/vendor/qcom-opensource/rh-patch/-/commit/447f2135909683d1385af36f95fae5e1d63a7e2f Personally I'd remove the mention of the downstream kernel is this case. Also your paragraphs are formatted weird with a newline at the end of every sentence. Get them to flow together as a regular paragraph. This is the relevant line that I have in my muttrc file to help. set editor="vim -c 'set spell spelllang=en' -c 'set tw=72' -c 'set wrap'" > rcu: INFO: rcu_preempt self-detected stall on CPU > rcu: 0-....: (1 GPs behind) idle=77fc/1/0x4000000000000004 softirq=841/841 fqs=2476 > rcu: (t=5253 jiffies g=-175 q=2552 ncpus=8) > Call trace: > __do_softirq > ____do_softirq > call_on_irq_stack > do_softirq_own_stack > __irq_exit_rcu > irq_exit_rcu > > The issue occurs normally once every 3-4 boot cycles. > There is likely a race condition caused when setting up the two pcie > domains concurrently (pcie2a and pcie3a). I would also add that Qualcomm told us that upgrading the firmware on the PCIe switch would correct this issue. We've upgraded the PCIe switch to the latest firmware and this issue is still present. Apparently we need to use a specific older version of the firmware that we can't get from the PCIe switch vendor or Qualcomm. Nothing is hooked up to pcie2a on the QDrive3 so there's no loss in functionality by disabling this. We always have to remember to revert this commit when working with an upstream kernel. > This is not a solution, so this patch is disabling pcie2a as it seems > Red Hat are the only ones working on the board, > we're find with disabling the node until a root cause is found. If > anyone has further suggestions for debugging, let me know. This should go under the ---. Brian