From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59A5FEB64DD for ; Tue, 11 Jul 2023 11:10:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231258AbjGKLKW (ORCPT ); Tue, 11 Jul 2023 07:10:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231509AbjGKLKU (ORCPT ); Tue, 11 Jul 2023 07:10:20 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AE7798; Tue, 11 Jul 2023 04:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689073820; x=1720609820; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pnPOejrtBmciSuneX2GIuca/d8m7aJiJ68yCzAIAa8Y=; b=a3psuEUGflv0Lf2XwL6CQ10Tn+HqIJrcbOAhrGUGiaWliK68JL0iYiRX EkmhJHwXfY3pn1Ve+rIwRjVPzL0o2smyeU1EfTMtC/GmJg7yxWwgxd5KU oMZHvGwvsoh6XCSGuOFlcuDwBvOs72gSh1jHIs1qIFlyvrdPWQzX8citu a/oMT4eCgInTrjUum52JysaDHJNbfaJ/bRNtxR5bOQgS46RXPC85rPVKv f6j8FvYR3xEW+7eYkqK5qxSB+VwLsBCvr3BQB/fY7DgZaNaFDz5IFu+KO Yd1MwdSZPVAx1XonXsIzE5egReRzXcESLYas7GDOu5dob2jwrTwAZTp6C g==; X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="344909461" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="344909461" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2023 04:10:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="834644461" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="834644461" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 11 Jul 2023 04:10:08 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qJBFs-001pGf-16; Tue, 11 Jul 2023 14:10:04 +0300 Date: Tue, 11 Jul 2023 14:10:04 +0300 From: Andy Shevchenko To: Mark Brown Cc: Cristian Ciocaltea , Yang Yingliang , Amit Kumar Mahapatra via Alsa-devel , Neil Armstrong , Tharun Kumar P , Vijaya Krishna Nivarthi , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, Sanjay R Mehta , Radu Pirea , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Tudor Ambarus , Serge Semin , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Andy Gross , Bjorn Andersson , Konrad Dybcio , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Max Filippov , Steven Rostedt , Masami Hiramatsu , Richard Cochran Subject: Re: [PATCH v2 08/15] spi: Clean up headers Message-ID: References: <20230710154932.68377-1-andriy.shevchenko@linux.intel.com> <20230710154932.68377-9-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Jul 11, 2023 at 09:26:46AM +0100, Mark Brown wrote: > On Mon, Jul 10, 2023 at 06:49:25PM +0300, Andy Shevchenko wrote: > > There is a few things done: > > - include only the headers we are direct user of > > - when pointer is in use, provide a forward declaration > > - add missing headers > > - group generic headers and subsystem headers > > - sort each group alphabetically > > This breaks an x86 allmodconfig build: Yeah, it was too brave to go. That's actually the answer why I left mod_devicetable.h included. (However the mod_devicetable.h probably should stay to be similar to i2c.h. Let's postpone this one, but it's good to have the build report so we know which drivers are missing GPIO header to be included. -- With Best Regards, Andy Shevchenko