From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32E34EB64D9 for ; Mon, 10 Jul 2023 08:19:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229998AbjGJITK (ORCPT ); Mon, 10 Jul 2023 04:19:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233092AbjGJISy (ORCPT ); Mon, 10 Jul 2023 04:18:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C1E2FB; Mon, 10 Jul 2023 01:17:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2149B60B38; Mon, 10 Jul 2023 08:17:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B392C433C8; Mon, 10 Jul 2023 08:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688977033; bh=o21HF+UQcS0l3yAQUuKG4zuD/R+bPXKc2OVpaRoiVgY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n40nmwMw1E+wUBhSn66EV2a1HkmIgPT+NPilR6uVX5pfjZPL2n4/pipwhgcYytccu LbRUzBWO8+JndLw3pQw/UEkD0zuG9HVplY4imqP+0pFG1EKcJVLEGMIw5t423kXXzW uSBl7lbDma9jbUlCIv8gsO5tAle78cBiCVl07CeDfTJgjnG5DO+No2rc00ZhO9UxZc TxiHU605qD7qjhd/B3olEmSDQwRoy8RizVGyrVIE+oybl8N/eUpBc6x56DkH1sTT2m 4bmotqdAEBfXx9pMdTmAXu020eottw9EV3NZqP+LLCJnVjfrl7NXezK5OqdlF1uUQc vh5IDhxWOUIDg== Received: from johan by xi.lan with local (Exim 4.96) (envelope-from ) id 1qIm5T-0007yi-0p; Mon, 10 Jul 2023 10:17:39 +0200 Date: Mon, 10 Jul 2023 10:17:39 +0200 From: Johan Hovold To: Srinivas Kandagatla , Vinod Koul Cc: andersson@kernel.org, yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] soundwire: qcom: update status correctly with mask Message-ID: References: <20230525133812.30841-1-srinivas.kandagatla@linaro.org> <20230525133812.30841-2-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230525133812.30841-2-srinivas.kandagatla@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, May 25, 2023 at 02:38:09PM +0100, Srinivas Kandagatla wrote: > SoundWire device status can be incorrectly updated without > proper mask, fix this by adding a mask before updating the status. > > Fixes: c7d49c76d1d5 ("soundwire: qcom: add support to new interrupts") > Signed-off-by: Srinivas Kandagatla > --- When rebasing on 6.5-rc1, I noticed that this one was apparently never merged along with the rest of the series. Any idea how this could have happened? And can we get this one into 6.5 as well? > drivers/soundwire/qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index aad5942e5980..9440787e924b 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -515,7 +515,7 @@ static int qcom_swrm_get_alert_slave_dev_num(struct qcom_swrm_ctrl *ctrl) > status = (val >> (dev_num * SWRM_MCP_SLV_STATUS_SZ)); > > if ((status & SWRM_MCP_SLV_STATUS_MASK) == SDW_SLAVE_ALERT) { > - ctrl->status[dev_num] = status; > + ctrl->status[dev_num] = status & SWRM_MCP_SLV_STATUS_MASK; > return dev_num; > } > } Johan