From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E416EB64DD for ; Fri, 21 Jul 2023 10:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231731AbjGUKZS (ORCPT ); Fri, 21 Jul 2023 06:25:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231743AbjGUKY7 (ORCPT ); Fri, 21 Jul 2023 06:24:59 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 75C4D171E for ; Fri, 21 Jul 2023 03:24:51 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 99A0B2F4 for ; Fri, 21 Jul 2023 03:25:34 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 05CF23F738 for ; Fri, 21 Jul 2023 03:24:50 -0700 (PDT) Date: Fri, 21 Jul 2023 11:24:33 +0100 From: Liviu Dudau To: Gaosheng Cui Cc: airlied@gmail.com, daniel@ffwll.ch, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, sean@poorly.run, marijn.suijten@somainline.org, neil.armstrong@linaro.org, sam@ravnborg.org, quic_eberman@quicinc.com, a39.skl@gmail.com, quic_gurus@quicinc.com, angelogioacchino.delregno@somainline.org, james.qian.wang@arm.com, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v3 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler() Message-ID: References: <20230714014820.2186203-1-cuigaosheng1@huawei.com> <20230714014820.2186203-4-cuigaosheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230714014820.2186203-4-cuigaosheng1@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Gaosheng, On Fri, Jul 14, 2023 at 09:48:20AM +0800, Gaosheng Cui wrote: > The komeda_pipeline_get_state() returns an ERR_PTR() on failure, we should > use IS_ERR() to check the return value. > > Fixes: 502932a03fce ("drm/komeda: Add the initial scaler support for CORE") > Signed-off-by: Gaosheng Cui > Reviewed-by: Liviu Dudau > --- > drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c > index 3276a3e82c62..e9c92439398d 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c > @@ -259,7 +259,7 @@ komeda_component_get_avail_scaler(struct komeda_component *c, > u32 avail_scalers; > > pipe_st = komeda_pipeline_get_state(c->pipeline, state); > - if (!pipe_st) > + if (IS_ERR(pipe_st)) If you're going to update the other patches to use IS_ERR_OR_NULL() please do so here too. You can keep my R-b for that change. Best regards, Liviu > return NULL; > > avail_scalers = (pipe_st->active_comps & KOMEDA_PIPELINE_SCALERS) ^ > -- > 2.25.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯