From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB6BDE7E65F for ; Tue, 26 Sep 2023 19:37:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231153AbjIZTh7 (ORCPT ); Tue, 26 Sep 2023 15:37:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229985AbjIZTh6 (ORCPT ); Tue, 26 Sep 2023 15:37:58 -0400 Received: from mo4-p03-ob.smtp.rzone.de (mo4-p03-ob.smtp.rzone.de [81.169.146.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ECDCFC; Tue, 26 Sep 2023 12:37:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695757045; cv=none; d=strato.com; s=strato-dkim-0002; b=PzFhlSDazxWtUIhv8D+p4rJGZjG2FvvZo8iULTAM3w1PsNvsjYjXuPStvSeWVkuVNJ nt19eoOBbKwnQFCHTVpqLLfKzUkMQ9u8/veSCeonhbgHNck7y3OdzrRsl8+H5s7VRKNk 9NxCH5c1Z46fENY7u6cNskztzygzmJK1JNDfViOBqykcOkmGBBMIGDeqtb7/SvDl4n9x qIwdah5XxwjcZso5N1LMjXnOmPhJJYzDaqyh/lyA18gAa/q7+v8YtmRaIsUTC+tbmO/r O0rkQ3jVR/wF21oRNBwtnoLAHGnTIkpaFFTRKMGu7/RfG7c2CyEUbGdzbizo6+vOZkR6 qcPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1695757045; s=strato-dkim-0002; d=strato.com; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=V9JO3H32BjHUMfYT7D/OSucGSORMhp/WvjBp8dje0LE=; b=Eq4P6ks9tem4GBbhp9gtrupOlPsApxSmAl9pmVzL9Koqk3aaaUI7u8ne1K1OCEVzCN xT16GhZJhMXCYUQD8vbSk0S8SkzcmT929umEJoYkgBqShACdu9RZVd7QrDHBl1tI1nYV bz/G+YOMI4XF6HJM5swOXRtki5pdPg2cE4mXase0xOsQ4ZnFgs3EPqPi8Y5HKMy0wg48 XKYCqMiiqYeM8vb4aTyM2wsfguTdPpDSOXvyRX2zYiJOO7q2MtisNkz1L3gdbR+/VAAC IbWtCFR73LAc9EjomBKEIOiW/idrzgfwr5fZj7aYTkDQzDh2bQ8m5RhAXuhUYsO/3bbu 3EWQ== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo03 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1695757045; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=V9JO3H32BjHUMfYT7D/OSucGSORMhp/WvjBp8dje0LE=; b=bgr7QK1DS5lsH3hAC+vQCM1fxR+dDLP6c4xO8dlnUgKU0L/d2EZU9P7Q+cEkhD1lsB ZwzxTf6s6fTCiYJ2gcfs91l3s4vHctDSr7NYFnVwvCiYTYLj4HJ4CS7aFI/O6YNOlxcD ZaT0zbKX1nEOxyvVXBXx2YdFMZJpYNt+7nwhQnKfhxDsEPtBbv+Uy6JhuuWFKw3SIa11 sUcrdjnTBRd9lAOMa7j5/zgFevMQr4hSRf36qnaL4tAWUqBtAqBW2KmpoNixOS2Jvbn5 p+2gERP94rUnovk8xfGZYHU4qB7D8TSW9SblJoOW4qICHPztjlTdJgHXZY/lvluQkQbj VH9g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1695757045; s=strato-dkim-0003; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=V9JO3H32BjHUMfYT7D/OSucGSORMhp/WvjBp8dje0LE=; b=AThLtZQBDX/9TynlR7zX4grhWuQU/rIR6H4qOFRT4m9IRHrCFY/8UxSjb/ujzh1BEw wM6W8Ip1Yk4WBe7WGiBg== X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u261EJF5OxJD4paA8piJ1A==" Received: from gerhold.net by smtp.strato.de (RZmta 49.8.2 SBL|AUTH) with ESMTPSA id R04c57z8QJbPgO0 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 26 Sep 2023 21:37:25 +0200 (CEST) Date: Tue, 26 Sep 2023 21:37:23 +0200 From: Stephan Gerhold To: Konrad Dybcio Cc: Bjorn Andersson , Andy Gross , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Bryan O'Donoghue , Jasper Korten , Siddharth Manthan , Nikita Travkin Subject: Re: [PATCH 11/13] arm64: dts: qcom: msm8916-samsung-gt5: Add sound and modem Message-ID: References: <20230926-msm8916-modem-v1-0-398eec74bac9@gerhold.net> <20230926-msm8916-modem-v1-11-398eec74bac9@gerhold.net> <8b4de316-123f-455d-933a-c727daef918b@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8b4de316-123f-455d-933a-c727daef918b@linaro.org> Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Sep 26, 2023 at 09:03:14PM +0200, Konrad Dybcio wrote: > On 26.09.2023 18:51, Stephan Gerhold wrote: > > From: Jasper Korten > > > > Enable sound and modem for the Samsung Galaxy Tab A 2015 tablets. > > The setup is similar to most MSM8916 devices, i.e.: > > > > - QDSP6 audio > > - Headphones/microphones via digital/analog codec in > > MSM8916/PM8916. Earpiece exists on samsung-gt58 only. > > - WWAN Internet via BAM-DMUX > > > > except: > > > > - gt510: Stereo Maxim MAX98357A codecs for speaker on Quaternary MI2S > > - gt58: Mono NXP TFA9895 codec for speaker on Quaternary MI2S > > - For some reason connected to GPIOs where no hardware I2C > > controller is available -> need to use i2c-gpio > > - Samsung-specific audio jack detection (not supported yet) > > > > Signed-off-by: Jasper Korten > > Co-developed-by: Siddharth Manthan > > Signed-off-by: Siddharth Manthan > > Co-developed-by: Nikita Travkin > > Signed-off-by: Nikita Travkin > > [Stephan: Add consistent commit message] > > Signed-off-by: Stephan Gerhold > > --- > > .../boot/dts/qcom/msm8916-samsung-gt5-common.dtsi | 36 ++++++++++++++++++ > > arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dts | 23 ++++++++++++ > > arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts | 43 ++++++++++++++++++++++ > > 3 files changed, 102 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi > > index 6a16eb5ce07b..396853fcece5 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi > > @@ -3,9 +3,12 @@ > > /dts-v1/; > > > > #include "msm8916-pm8916.dtsi" > > +#include "msm8916-modem-qdsp6.dtsi" > > + > > #include > > #include > > #include > > +#include > > > > / { > > aliases { > > @@ -116,6 +119,17 @@ &blsp_uart2 { > > status = "okay"; > > }; > > > > +&lpass { > > + dai-link@3 { > > + reg = ; > > + qcom,playback-sd-lines = <1>; > > + }; > > +}; > status = reserved? > For reference: https://lore.kernel.org/linux-arm-msm/ZRMwdRo9hAm4BO5E@gerhold.net/ > [...] > > > > + i2c-amplifier { > > + compatible = "i2c-gpio"; > > + sda-gpios = <&tlmm 55 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; > > + scl-gpios = <&tlmm 56 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; > non-msm8916 files have a space around the OR operator, hm > Hm I can add a space if you think it looks better. :D Thanks, Stephan