From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E06A1CDB483 for ; Fri, 13 Oct 2023 12:05:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231381AbjJMMFl (ORCPT ); Fri, 13 Oct 2023 08:05:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231452AbjJMMFk (ORCPT ); Fri, 13 Oct 2023 08:05:40 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7C27CE; Fri, 13 Oct 2023 05:05:38 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67647C433C7; Fri, 13 Oct 2023 12:05:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697198738; bh=nzkUtLBqmirZ6m/6sa9MukyVECkrLso7I7MyMjnA/gA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b35zLxn+F38/TILhl6VO9FmvMCSuPNzIzpLpZP/jSMd2JDh4SEwthFaIjP0ODkdO3 HNLOXWKvywrH9gZ/vLIXaTGucPlEoeG/eUyM0U6zc0ZhQkKuxp+78PJyK0P0ePXx9z K3F3pnukV15Ld7Z+WWjcxRHnMXAJ9MQJoag8ODDaAyba7gAoRYV8FvipC5yvInrEDZ Foo1vxyJJ7zM8BqsXdVvr+wCHfCdIJIBjVEmyb8u4GYvuTLEy8IcB9NiL5Glk9O4XX b86ICOUpCa3IezU9mi3Oxv3HWhYpStHNMSMWnT8podKi7Aa4G3FmOdEV5UkHBL0i+5 8vNXJdsdg4m0Q== Received: from johan by xi.lan with local (Exim 4.96) (envelope-from ) id 1qrGvh-0000sd-1v; Fri, 13 Oct 2023 14:06:09 +0200 Date: Fri, 13 Oct 2023 14:06:09 +0200 From: Johan Hovold To: Kuogee Hsieh Cc: robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, dianders@chromium.org, vkoul@kernel.org, daniel@ffwll.ch, airlied@gmail.com, agross@kernel.org, dmitry.baryshkov@linaro.org, andersson@kernel.org, marijn.suijten@somainline.org, quic_abhinavk@quicinc.com, quic_jesszhan@quicinc.com, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] drm/msm/dp: do not reinitialize phy unless retry during link training Message-ID: References: <1691533190-19335-1-git-send-email-quic_khsieh@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Oct 03, 2023 at 11:10:59AM +0200, Johan Hovold wrote: > On Tue, Aug 08, 2023 at 03:19:50PM -0700, Kuogee Hsieh wrote: > > DP PHY re-initialization done using dp_ctrl_reinitialize_mainlink() will > > cause PLL unlocked initially and then PLL gets locked at the end of > > initialization. PLL_UNLOCKED interrupt will fire during this time if the > > interrupt mask is enabled. > > However currently DP driver link training implementation incorrectly > > re-initializes PHY unconditionally during link training as the PHY was > > already configured in dp_ctrl_enable_mainlink_clocks(). > > > > Fix this by re-initializing the PHY only if the previous link training > > failed. > > > > [drm:dp_aux_isr] *ERROR* Unexpected DP AUX IRQ 0x01000000 when not busy > > > > Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") > > Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/30 > > Signed-off-by: Kuogee Hsieh > > This fixes the above warning and avoids the unnecessary PHY power-off > and power-on during boot of the ThinkPad X13s: > > Reviewed-by: Johan Hovold > Tested-by: Johan Hovold > > I guess this one should go to stable as well: > > Cc: stable@vger.kernel.org # 5.10 > > Is anyone planning on getting this fixed in 6.6-rc? I noticed that this > one still hasn't shown up linux-next. For the record, this one showed up in a PR from Rob and has now been forwarded to Linus. No stable tag included, but I guess we can ping the stable team unless AUTOSEL picks this up. Johan