From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EB7ACA6A for ; Fri, 17 Nov 2023 11:00:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Jxl+z3Vz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA14EC433C8; Fri, 17 Nov 2023 11:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700218842; bh=UoF7Nr9aiLL6Qk9+QjG85dzn35c3D6g8QBytI8YPADI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jxl+z3VzPnLBZeIViaqu1FhM/werkN2mOFu08rv3pOAJsJyVdFXgBNTodjTs0TYOl jqgv9zVhJYR2O5fkAj46qgDLOomBp4baosr24oYttKXjc2NZ+pz1n3HU6DxoYTMVEg uu0lflv+4rO2s1sgm0w2VmOC0ynyutmeLDvPmtOfOEfyKPgmrWXw0SDD2NRcIsQxdq 2v2HSaAQS29TvhEX+wcSmOjPY74Vy+4gqt/Xb3at3kLxJ5PjgJX+5Sr19UaH67uezF YpBMMZTdiQOtpZTOxrwzKStfiuhxNUdxdCPY9EcfWZ6iXbCZSosgm4aHfESyrlSCGy w0VgkAlC7Esqw== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1r3waa-0002Mj-2a; Fri, 17 Nov 2023 12:00:45 +0100 Date: Fri, 17 Nov 2023 12:00:44 +0100 From: Johan Hovold To: Manivannan Sadhasivam Cc: Johan Hovold , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Nirmal Patel , Jonathan Derrick , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] PCI: qcom: Clean up ASPM comment Message-ID: References: <20231114135553.32301-1-johan+linaro@kernel.org> <20231114135553.32301-5-johan+linaro@kernel.org> <20231117103227.GM250770@thinkpad> <20231117105404.GR250770@thinkpad> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231117105404.GR250770@thinkpad> On Fri, Nov 17, 2023 at 04:24:04PM +0530, Manivannan Sadhasivam wrote: > On Fri, Nov 17, 2023 at 11:48:10AM +0100, Johan Hovold wrote: > > On Fri, Nov 17, 2023 at 04:02:27PM +0530, Manivannan Sadhasivam wrote: > > > On Tue, Nov 14, 2023 at 02:55:51PM +0100, Johan Hovold wrote: > > > > Break up the newly added ASPM comment so that it fits within the soft 80 > > > > character limit and becomes more readable. > > > > > > > > Signed-off-by: Johan Hovold > > > > > > I think we discussed (80column soft limit for comments) in the past, but I don't > > > think breaking here makes the comment more readable. > > > > The coding style clearly states: > > > > The preferred limit on the length of a single line is 80 columns. > > > > Statements longer than 80 columns should be broken into sensible chunks, > > unless exceeding 80 columns significantly increases readability and does > > not hide information. > > > > Going beyond 80 chars may sometimes be warranted for code, but the > > exception is not intended for comments. > > Breaking the comment here is indeed making it hard to read. It's just one word > that needs to be broken if we go by 80 column limit and I won't prefer that, > sorry! Please read the above quote again, it is as clear as it gets. 80 chars is the preferred limit unless (for code) exceeding it *significantly* increases readability, which clearly isn't the case here (even if this exception applied to comments). I really don't understand why you keep insisting on this. Just fix your editor. Johan