From: Johan Hovold <johan@kernel.org>
To: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
Cc: Andrew Halaney <ahalaney@redhat.com>,
Johan Hovold <johan+linaro@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Wesley Cheng <quic_wcheng@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 2/3] USB: dwc3: qcom: fix wakeup after probe deferral
Date: Tue, 21 Nov 2023 15:35:35 +0100 [thread overview]
Message-ID: <ZVzANwndkuzhBOiO@hovoldconsulting.com> (raw)
In-Reply-To: <ac838113-501a-4f2b-b858-c59f586a9f35@quicinc.com>
On Tue, Nov 21, 2023 at 07:38:18PM +0530, Krishna Kurapati PSSNV wrote:
> >> Just one query. Even if it wakes up after closing the lid and removing
> >> the mouse, wouldn't pm suspend be triggered again later by the system
> >> once it sees that usb is also good to be suspended again ? I presume a
> >> laptop form factor would be having this facility of re-trigerring
> >> suspend. Let me know if this is not the case.
> >
> > No, we generally don't use opportunistic suspend (e.g. unlike android)
> > so the laptop will not suspend again.
> >
> > So this is an actual bug affecting, for example, the Lenovo ThinkPad
> > X13s.
> Thanks for the clarification. I was thinking in android perspective
> only. But if we don't wake up the system upon disconnect, wouldn't the
> controller still be under the assumption that device is connected when
> it is actually not and only realise this when we resume later ?
Correct.
Johan
next prev parent reply other threads:[~2023-11-21 14:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 16:16 [PATCH 0/3] USB: dwc3: qcom: fix wakeup after probe deferral Johan Hovold
2023-11-20 16:16 ` [PATCH 1/3] dt-bindings: usb: qcom,dwc3: fix example wakeup interrupt types Johan Hovold
2023-11-20 18:19 ` Krzysztof Kozlowski
2023-11-20 16:16 ` [PATCH 2/3] USB: dwc3: qcom: fix wakeup after probe deferral Johan Hovold
2023-11-20 17:39 ` Andrew Halaney
2023-11-20 20:50 ` Andrew Halaney
2023-11-21 9:17 ` Johan Hovold
2023-11-21 12:55 ` Krishna Kurapati PSSNV
2023-11-21 13:50 ` Johan Hovold
2023-11-21 14:08 ` Krishna Kurapati PSSNV
2023-11-21 14:35 ` Johan Hovold [this message]
2023-11-20 16:16 ` [PATCH 3/3] USB: dwc3: qcom: simplify wakeup interrupt setup Johan Hovold
2023-11-21 14:04 ` [PATCH 0/3] USB: dwc3: qcom: fix wakeup after probe deferral Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVzANwndkuzhBOiO@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_kriskura@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox