From: Johan Hovold <johan@kernel.org>
To: Krishna Kurapati <quic_kriskura@quicinc.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, quic_ppratap@quicinc.com,
quic_jackp@quicinc.com
Subject: Re: [PATCH v2 2/6] usb: dwc3: qcom: Rename hs_phy_irq to qusb2_phy_irq
Date: Thu, 7 Dec 2023 16:28:39 +0100 [thread overview]
Message-ID: <ZXHkpwji_AzXMjfm@hovoldconsulting.com> (raw)
In-Reply-To: <20231204100950.28712-3-quic_kriskura@quicinc.com>
On Mon, Dec 04, 2023 at 03:39:46PM +0530, Krishna Kurapati wrote:
> For wakeup to work, driver needs to enable interrupts that depict what is
> happening on th DP/DM lines. On QUSB targets, this is identified by
typo: the
> qusb2_phy whereas on SoCs using Femto PHY, separate {dp,dm}_hs_phy_irq's
> are used instead.
>
> The implementation incorrectly names qusb2_phy interrupts as "hs_phy_irq".
> Clean this up so that driver would be using only qusb2/(dp & dm) for wakeup
> purposes.
Here too you should say something about why this won't break any systems
booting using an older devicetree. Specifically, the QUSB2 PHY interrupt
has never been armed on any system running mainline as those bits never
made it upstream.
So an alternative to this could also be to just drop the QUSB2 PHY
interrupt handling from this driver for now.
Johan
next prev parent reply other threads:[~2023-12-07 15:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 10:09 [PATCH v2 0/6] Refine USB interrupt vectors on Qualcomm platforms Krishna Kurapati
2023-12-04 10:09 ` [PATCH v2 1/6] dt-bindings: usb: dwc3: Clean up hs_phy_irq in bindings Krishna Kurapati
2023-12-07 15:23 ` Johan Hovold
2023-12-07 15:44 ` Krishna Kurapati PSSNV
2023-12-07 16:13 ` Johan Hovold
2023-12-08 16:29 ` Rob Herring
2023-12-09 8:02 ` Krzysztof Kozlowski
2023-12-04 10:09 ` [PATCH v2 2/6] usb: dwc3: qcom: Rename hs_phy_irq to qusb2_phy_irq Krishna Kurapati
2023-12-07 15:28 ` Johan Hovold [this message]
2023-12-07 15:47 ` Krishna Kurapati PSSNV
2023-12-07 16:34 ` Johan Hovold
2023-12-08 12:14 ` Krishna Kurapati PSSNV
2023-12-04 10:09 ` [PATCH v2 3/6] arm64: dts: qcom: Fix hs_phy_irq for QUSB2 targets Krishna Kurapati
2023-12-07 15:32 ` Johan Hovold
2023-12-04 10:09 ` [PATCH v2 4/6] arm64: dts: qcom: Fix hs_phy_irq for non-QUSB2 targets Krishna Kurapati
2023-12-04 10:09 ` [PATCH v2 5/6] arm64: dts: qcom: Fix hs_phy_irq for SDM670/SDM845/SM6350 Krishna Kurapati
2023-12-04 10:09 ` [PATCH v2 6/6] arm64: dts: qcom: Add missing interrupts for qcs404/ipq5332 Krishna Kurapati
2023-12-07 15:36 ` Johan Hovold
2023-12-07 14:53 ` [PATCH v2 0/6] Refine USB interrupt vectors on Qualcomm platforms Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXHkpwji_AzXMjfm@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_jackp@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).