From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 04/15] clk: qcom: gcc-sm6375: Add runtime PM
Date: Wed, 20 Dec 2023 10:26:43 +0100 [thread overview]
Message-ID: <ZYKzU4FFCc9lnE-p@hovoldconsulting.com> (raw)
In-Reply-To: <20230717-topic-branch_aon_cleanup-v3-4-3e31bce9c626@linaro.org>
On Wed, Dec 20, 2023 at 01:30:45AM +0100, Konrad Dybcio wrote:
> The GCC block on SM6375 is powered by the VDD_CX rail. We need to ensure
> that CX is enabled to prevent unwanted power collapse
As I pointed out earlier, this bit of the commit message is incorrect
and misleading as the power domain will never be disabled until you
enable runtime PM as part of this very patch:
https://lore.kernel.org/all/ZLaSpFFBzP_Yz5yY@hovoldconsulting.com/
Specifically, genpd will not power off CX (at runtime) while the driver
is bound when runtime PM is left disabled.
> and that the
> reference is dropped when unused so that the system can enter a
> firmware-managed lower power state.
>
> Enable runtime PM to keep the power flowing only when necessary.
The rest is correct.
Johan
next prev parent reply other threads:[~2023-12-20 9:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 0:30 [PATCH v3 00/15] Unregister critical branch clocks + some RPM Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 01/15] clk: qcom: branch: Add a helper for setting the enable bit Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 02/15] clk: qcom: Use qcom_branch_set_clk_en() Konrad Dybcio
2023-12-20 8:25 ` Johan Hovold
2023-12-20 12:16 ` Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 03/15] clk: qcom: gcc-sm6375: Unregister critical clocks Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 04/15] clk: qcom: gcc-sm6375: Add runtime PM Konrad Dybcio
2023-12-20 9:26 ` Johan Hovold [this message]
2023-12-20 12:26 ` Konrad Dybcio
2023-12-20 12:48 ` Johan Hovold
2023-12-20 13:13 ` Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 05/15] clk: qcom: gpucc-sm6375: Unregister critical clocks Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 06/15] clk: qcom: gpucc-sm6115: " Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 07/15] clk: qcom: gpucc-sm6115: Add runtime PM Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 08/15] clk: qcom: gcc-sm6115: Unregister critical clocks Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 09/15] clk: qcom: gcc-sm6115: Add runtime PM Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 10/15] clk: qcom: gcc-qcm2290: Unregister critical clocks Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 11/15] clk: qcom: gcc-qcm2290: Add runtime PM Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 12/15] arm64: dts: qcom: sm6375: Add VDD_CX to GCC Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 13/15] arm64: dts: qcom: qcm2290: " Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 14/15] arm64: dts: qcom: sm6115: " Konrad Dybcio
2023-12-20 0:30 ` [PATCH v3 15/15] arm64: dts: qcom: sm6115: Add VDD_CX to GPU_CC Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYKzU4FFCc9lnE-p@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).