From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Abel Vesa <abel.vesa@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: x1e001de-devkit: Fix pin config for USB0 retimer vregs
Date: Fri, 11 Apr 2025 13:58:40 +0200 [thread overview]
Message-ID: <Z_kD8DJCPCJSu9-F@hovoldconsulting.com> (raw)
In-Reply-To: <abcf5f26-930a-4ce8-89ff-fc5405fe7b19@oss.qualcomm.com>
On Sat, Apr 05, 2025 at 01:08:46AM +0200, Konrad Dybcio wrote:
> On 3/18/25 4:50 PM, Abel Vesa wrote:
> > Describe the missing power source, bias and direction for each of the USB0
> > retimer gpio-controlled voltage regulators related pin configuration.
> >
> > Fixes: 019e1ee32fec ("arm64: dts: qcom: x1e001de-devkit: Enable external DP support")
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> > index 902335396c586a991c4a2de19906b039d887780f..8e88e00c335a05d0d36b4b08b85df82f38ef4355 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> > +++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> > @@ -1039,6 +1039,10 @@ rtmr0_default: rtmr0-reset-n-active-state {
> > usb0_3p3_reg_en: usb0-3p3-reg-en-state {
> > pins = "gpio11";
> > function = "normal";
> > + power-source = <1>; /* 1.8V */
>
> Not sure if I'm a fan of these comments but sure
How come?
Due to the incomplete bindings for these PMICs this is currently the
only way we have to document this information. And AFAIU the voltage
mapping can even differ from pin to pin on the same device.
I would prefer to see a space before the SI unit though.
Johan
next prev parent reply other threads:[~2025-04-11 11:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 15:50 [PATCH 0/2] arm64: dts: x1e001de-devkit: USB retimers related fixes Abel Vesa
2025-03-18 15:50 ` [PATCH 1/2] arm64: dts: qcom: x1e001de-devkit: Describe USB retimers resets pin configs Abel Vesa
2025-04-04 23:08 ` Konrad Dybcio
2025-03-18 15:50 ` [PATCH 2/2] arm64: dts: qcom: x1e001de-devkit: Fix pin config for USB0 retimer vregs Abel Vesa
2025-04-04 23:08 ` Konrad Dybcio
2025-04-11 11:58 ` Johan Hovold [this message]
2025-04-22 11:14 ` Abel Vesa
2025-05-13 20:46 ` [PATCH 0/2] arm64: dts: x1e001de-devkit: USB retimers related fixes Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_kD8DJCPCJSu9-F@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_sibis@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox