From: Abel Vesa <abel.vesa@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: PCI: qcom: Document the X1E80100 PCIe Controller
Date: Mon, 29 Jan 2024 16:36:29 +0200 [thread overview]
Message-ID: <Zbe37Rr8LRNxEurs@linaro.org> (raw)
In-Reply-To: <3aa071cc-32f2-4228-bd32-6dc2375a4c2c@kernel.org>
On 24-01-29 15:19:46, Krzysztof Kozlowski wrote:
> On 29/01/2024 12:10, Abel Vesa wrote:
> > Document the PCIe Controllers on the X1E80100 platform. They are similar
> > to the ones found on SM8550, but they don't have SF QTB clock.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> Tools like b4 or scripts_getmaintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, use mainline), work on fork of kernel (don't, use
> mainline) or you ignore some maintainers (really don't). Just use b4 and
> all the problems go away.
>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
Oups, forgot to run "b4 prep --auto-to-cc" after I added the bindings
patch.
Sorry about that. Will resend v2.
>
> Please kindly resend and include all necessary To/Cc entries.
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-01-29 14:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 11:10 [PATCH v2 0/2] PCI: qcom: Add PCIe support for X1E80100 Abel Vesa
2024-01-29 11:10 ` [PATCH v2 1/2] dt-bindings: PCI: qcom: Document the X1E80100 PCIe Controller Abel Vesa
2024-01-29 14:19 ` Krzysztof Kozlowski
2024-01-29 14:36 ` Abel Vesa [this message]
2024-02-02 12:44 ` Manivannan Sadhasivam
2024-01-29 11:10 ` [PATCH v2 2/2] PCI: qcom: Add X1E80100 PCIe support Abel Vesa
2024-02-01 19:20 ` Konrad Dybcio
2024-02-02 8:13 ` neil.armstrong
2024-02-02 8:41 ` Manivannan Sadhasivam
2024-02-02 10:31 ` Abel Vesa
2024-02-02 12:43 ` Manivannan Sadhasivam
2024-02-02 8:41 ` Abel Vesa
2024-02-02 8:44 ` neil.armstrong
2024-02-02 8:51 ` Abel Vesa
2024-02-02 8:48 ` Manivannan Sadhasivam
2024-02-02 8:55 ` Abel Vesa
2024-02-02 9:31 ` Abel Vesa
2024-02-02 9:48 ` Manivannan Sadhasivam
2024-02-02 12:44 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zbe37Rr8LRNxEurs@linaro.org \
--to=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzk@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).