From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E6D260BBD for ; Fri, 2 Feb 2024 09:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706866316; cv=none; b=WEs/aNbgcs54KAY7A0mgcWkUaQj8amzUfhHamfaAEYxlR+3QN0i5uxSLy8lcD78vW/FfbFE34CkvtuwbXk2LjyoCulYufg0u78siPGH5uu10yycC9Z+THJWrnIhtmIdtcwVuJbihaiB8WLg4TVkrJAlXvhroT/HczTfQvX36e6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706866316; c=relaxed/simple; bh=qemFVdz8drhJlZ2QFPkmnp00qePRuil7WJFA99tBSIE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zne6iqX8P6qdfNcTEGLMIke4a6xi76jEEhRcWzOGgmmNdV+EcTNA8sXY1tTnz+E7r2JPT6GR1lcXINJv3OzQU71NkYuBkTXWUfxBSLhed/Uz+PuYlfT7rswviEwBcG2Cbew/N22GHGwmhy1JP3BrPFXoIv6OV6f/CnWAvNA1PtM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=foD40yoc; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="foD40yoc" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a35e65df2d8so253063466b.0 for ; Fri, 02 Feb 2024 01:31:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706866312; x=1707471112; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KoEIyCsLXaY7M3crxGURKXz5Fgd745HNqfUsmEwe3DI=; b=foD40yocJ1RMuM40SWqBNUe6OY51W1V72Ll2Y/y/X3fHz/Zq+MJBC8JGA5GD9rwnp9 Sqcrkkc2D79Iq44iCNjB1ILFhfhwJUXRAuFCESvi/3hPFGX3ba16gBZ8q0bS8mPBq3PO DQs+kN1RbYmMU6xaUlXjsXxlHihBxJisn3ldhsYRMnHbrz3nvoOfIJ9dE/XtBbxuBrfp rS7fEqvWnjohQm75H3MrAPrYhi29mw8wYp0G2WsiAHVtn5apzORjxBJob7OdK8+PPi/3 tSU10EwLldceC6rQ9T5Pb+xxOmAdjxctfah2B+uHILCwFm503PXHTzRfM+J/LBYfYQQL xbbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706866312; x=1707471112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KoEIyCsLXaY7M3crxGURKXz5Fgd745HNqfUsmEwe3DI=; b=o+8yR613J2hx+t6OPXd6vg08UPcOHxg3j6FSG5790zu1esKLsNyTrirehjcpgnVThu 6mIF3qO66SKGTC89KRCzz4pta68aHFGc1y8dCLz60nwKREe6WbpFy7IdwuW+UktFOLSQ B1kARxmQRJr3qw3PBfV3bQ86+XukbHp5jT7hTr9if6Y2z48/bQNz6/l8uRMht+ldjqeE GxEKf7iZGy1MmkWmFiinCqvgDNRL+WoCKKznFtRDYaCN1THLVTLkRB64iktUB400sNd0 k2r0N9DdbUuzCXyHrJbNPNV4LHuEY3gzA54GTd/Cm7aYJ7UDeU4lDRdVdZX7M+qSXqAC fOHQ== X-Gm-Message-State: AOJu0YynB9i4lP2Xpro7moaOF3/nPV4/RrNiuEuSNcqvPouAVb872ynu OkjwiYp7zCAKd50sdOgB6st80XqBDMkxzbad7AD2AzXgJ4N2WxAUhodkpY7e4kI= X-Google-Smtp-Source: AGHT+IFpHZDB0Lm8TPIyEfnx56tN25N83gV3zu+CXiaU244TUMOytO72oVOCB5SCR2SLGLpFY0LLdA== X-Received: by 2002:a17:906:a1d6:b0:a36:3345:be88 with SMTP id bx22-20020a170906a1d600b00a363345be88mr1140545ejb.30.1706866312409; Fri, 02 Feb 2024 01:31:52 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCX9V0zc+gDtDPzFvLCjzRe+iabJaGddwMMexlbprkGRefzc925muTOFNriF1N9L3/5Mf/JIkTuXJZOhm5hDDI7Dl+LLkoma5He0bVoUrUsL0LsmR5Gr1m9E7J4VlWvTx/6e1gljMB2q9eBxIks5lMa524hAGeQ5tcCGmlvndoYorD9Uz5wKMn3ErNa5KRoQlxJRbsitWIAwxU6RMRusSFW11nscwerb42R7/eglRu4Nk+bDeu1CVG9JctRqD4TftQwca4eKYnp8FrwbRuej0f+jkPtI9fWjklzNsmmRi7xP2794DQiAg2w= Received: from linaro.org ([62.231.97.49]) by smtp.gmail.com with ESMTPSA id sd25-20020a170906ce3900b00a359558648esm696796ejb.24.2024.02.02.01.31.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 01:31:52 -0800 (PST) Date: Fri, 2 Feb 2024 11:31:50 +0200 From: Abel Vesa To: Manivannan Sadhasivam Cc: Konrad Dybcio , Bjorn Andersson , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] PCI: qcom: Add X1E80100 PCIe support Message-ID: References: <20240129-x1e80100-pci-v2-0-a466d10685b6@linaro.org> <20240129-x1e80100-pci-v2-2-a466d10685b6@linaro.org> <30360d96-4513-40c4-9646-e3ae09121fa7@linaro.org> <20240202084806.GF2961@thinkpad> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 24-02-02 10:55:28, Abel Vesa wrote: > On 24-02-02 14:18:06, Manivannan Sadhasivam wrote: > > On Fri, Feb 02, 2024 at 10:41:03AM +0200, Abel Vesa wrote: > > > On 24-02-01 20:20:40, Konrad Dybcio wrote: > > > > On 29.01.2024 12:10, Abel Vesa wrote: > > > > > Add the compatible and the driver data for X1E80100. > > > > > > > > > > Signed-off-by: Abel Vesa > > > > > --- > > > > > drivers/pci/controller/dwc/pcie-qcom.c | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > > > > index 10f2d0bb86be..2a6000e457bc 100644 > > > > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > > > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > > > > @@ -1642,6 +1642,7 @@ static const struct of_device_id qcom_pcie_match[] = { > > > > > { .compatible = "qcom,pcie-sm8450-pcie0", .data = &cfg_1_9_0 }, > > > > > { .compatible = "qcom,pcie-sm8450-pcie1", .data = &cfg_1_9_0 }, > > > > > { .compatible = "qcom,pcie-sm8550", .data = &cfg_1_9_0 }, > > > > > + { .compatible = "qcom,pcie-x1e80100", .data = &cfg_1_9_0 }, > > > > > > > > I swear I'm not delaying everything related to x1 on purpose.. > > > > > > > > > > No worries. > > > > > > > But.. > > > > > > > > Would a "qcom,pcie-v1.9.0" generic match string be a good idea? > > > > > > Sure. So that means this would be fallback compatible for all the following platforms: > > > > > > - sa8540p > > > - sa8775p > > > - sc7280 > > > - sc8180x > > > - sc8280xp > > > - sdx55 > > > - sm8150 > > > - sm8250 > > > - sm8350 > > > - sm8450-pcie0 > > > - sm8450-pcie1 > > > - sm8550 > > > - x1e80100 > > > > > > Will prepare a patchset. > > > > > > > NO. Fallback should be based on the base SoC for this platform. > > Right, so since the SM8250 is the one that has the core version 1.9.0, > should we just the sm8550 compatible as fallback for all other ones. > > Yes, I know that there is SM8150, which has core version 1.5.0, but it > is still 1.9.0 compatible. > > Or maybe we should rename the config to 1_5_0 and have the sm8150 > compatible as fallback for all these platforms. > Actually no, that's a bad idea. I would break DT backwards compatibility. I'll just drop the compatible from driver and add fallback in DT for X1E80100. > > > > - Mani > > > > -- > > மணிவண்ணன் சதாசிவம்