From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29933537F0; Wed, 3 Apr 2024 07:06:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712127964; cv=none; b=BlE70Kv0Elqe0ZFkDacP3h63PRIbqvH9m5oZ/fyln/NW/g8Eui4EmXrAY27q0vjdRwEOTj20cjrtq9uAiaUL409hpvy/iq/JJeZ0aanrNlzmahNPWYlre1dV/r9veRFuwAPhZ5W05EqkLFBB+9hHN8x24ap7TLJQK57BhnvYJ0E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712127964; c=relaxed/simple; bh=pLe1zO2KxOqFTC50hG8lKBdb2ln2PJxOAj1b7Rg2kIo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oTVPmI+gCqivxOYQG33m8qN03maXDy7hoqs0Kf5WEU9fG3eEMpxKvTSHl7DkzEuE1BIbME4RxYJ7CtTKaSXgjVeFZ7cppwMpgo6HhT34d+xc0H8hJu4iyBfOmYk3uLR6c2YnMMjdapU5mZOBdztUm3LgZaqj5nkYAPw900vmjfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Zsqgg+cE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zsqgg+cE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECE52C433F1; Wed, 3 Apr 2024 07:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712127964; bh=pLe1zO2KxOqFTC50hG8lKBdb2ln2PJxOAj1b7Rg2kIo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zsqgg+cEZQMPJJMhRULn+C1BAygbh1Jo+iW/fdyZq38BLsH1GQlSSiLdKKVmIubdl JPv/ktx6eD1Fer7jBzWejLrYpKWe5qGj9woXlvdU6gTT5yazsOjInI65kTaSR1KriK 4Z9uUD/QhThZzfY5cjtpOda9SCsMu/xiQpe8iGWXHmjPOn2q5mcKYWSLjcWTzyUq2k g8suoptVxiw0vnVB8qX1rRlWfOD6qKassulNDmKmBcfB/nLz++BhhN9G0QTvEN67tN 5neo1wSUKQsZLRPIyF2tlXPl3wGkbuz3Cl2opHP29bv/13s4Iz5eaFyJaiJQjboQtD kBMHljPftTyBw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rruhA-000000007BG-01yh; Wed, 03 Apr 2024 09:06:04 +0200 Date: Wed, 3 Apr 2024 09:06:04 +0200 From: Johan Hovold To: Krishna Kurapati PSSNV Cc: Thinh Nguyen , Krzysztof Kozlowski , Rob Herring , Bjorn Andersson , Wesley Cheng , Konrad Dybcio , Greg Kroah-Hartman , Conor Dooley , Felipe Balbi , "devicetree@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "quic_ppratap@quicinc.com" , "quic_jackp@quicinc.com" , Johan Hovold Subject: Re: [PATCH v18 2/9] usb: dwc3: core: Access XHCI address space temporarily to read port info Message-ID: References: <20240326113253.3010447-1-quic_kriskura@quicinc.com> <20240326113253.3010447-3-quic_kriskura@quicinc.com> <20240402233218.5kngtj56qellnrmo@synopsys.com> <39010f95-b08f-4a57-b3af-f34eb1069865@quicinc.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39010f95-b08f-4a57-b3af-f34eb1069865@quicinc.com> On Wed, Apr 03, 2024 at 10:54:25AM +0530, Krishna Kurapati PSSNV wrote: > >> +static int dwc3_read_port_info(struct dwc3 *dwc) > >> +{ > >> + void __iomem *base; > >> + u8 major_revision; > >> + u32 offset; > >> + u32 val; > >> + > >> + /* > >> + * Remap xHCI address space to access XHCI ext cap regs since it is > >> + * needed to get information on number of ports present. > >> + */ > >> + base = ioremap(dwc->xhci_resources[0].start, > >> + resource_size(&dwc->xhci_resources[0])); > >> + if (IS_ERR(base)) > >> + return PTR_ERR(base); > > > > Looks like you forgot to address some of the comments you said you'd > > update previously if you submit a new version to the series. > > > > [*] https://lore.kernel.org/linux-usb/af73110d-e13e-4183-af11-aed869ac0a31@quicinc.com/ > > > > Apologies. I agree. I was too much focused on acpi removal and interrupt > cleanup, I forgot the last comment you gave. > > Can I send in a separate patch for this ? The series has not been merged yet so you can address both issues in a v19. Perhaps wait a day or two in case Thinh has further comments. Johan