From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE5B745025; Tue, 30 Apr 2024 08:05:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714464350; cv=none; b=b9AO1dqyh0M+kwRByHvxSSS5R1wNjHj1Xi5rtv3t+zhDm5maBaXxFmEVixBD/4ynCn2VIxkdYbLlVi4thuYrgciwK06xwheqXuu+bzKYdK+D5EGxnEF6iC/pKlVLr4mteclxBhGZBsokRLc1JlkpZ6cZXVy1VV9jidcLo9DnqqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714464350; c=relaxed/simple; bh=fZlcYqSpR1qIHI7+FV0GRGg/1UW0j86/RtjUAe6cOus=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u/TdzAAfc9YIH484VzKcXrROaf8FgO9ESJIFP4n9YKZXLQlCo3uvWYkpYG7dfwg5X8qo73cLu6GzRsW8fAKq0txCKo16JLbUDuhBTo28zHG/jWtbaDMmKHjMu/TFpqhi5VT9D8SMHdh5zt311+d47IeJBjhbixu8ibeap5QGxjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HDYceixi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HDYceixi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56A45C2BBFC; Tue, 30 Apr 2024 08:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714464349; bh=fZlcYqSpR1qIHI7+FV0GRGg/1UW0j86/RtjUAe6cOus=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HDYceixiVNKl2rZlwhH+0mqIn8qgRF2jmeFy+1zJQ7sdotsRnp+s5JhFXshq2e5iA xbtPfzzywFyv5jMJVyexbxxKraVb+Q+wegepRKFMjVzNBYw/iNl1I8jzLTQek0XBMm OFbuhgHbu+2VMeM45hOAaz9E7QMHzSt3h4y3RnIoKXTkTQ6usC8KuR3vHFJ1YzyRZt LRPfmAmv7duacOC3FgSLe3lE2o7xjjlUxRK0moKsBfvWQ3gJ8XwXjOFtrnVii/PnKU Gy+Zdwi78MrBzdahIqXCM/B/jQpN50TQLTdURBdlnXJ5paJLUukxR8JnOvoOSv0sFb k32C9ZN/PXWKw== Date: Tue, 30 Apr 2024 10:05:42 +0200 From: Niklas Cassel To: Manivannan Sadhasivam Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Kishon Vijay Abraham I , Jingoo Han , Thierry Reding , Jonathan Hunter , linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mhi@lists.linux.dev, linux-tegra@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH v4 04/10] PCI: qcom-ep: Drop 'Link is enabled' from the debug message for BME event Message-ID: References: <20240430-pci-epf-rework-v4-0-22832d0d456f@linaro.org> <20240430-pci-epf-rework-v4-4-22832d0d456f@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240430-pci-epf-rework-v4-4-22832d0d456f@linaro.org> On Tue, Apr 30, 2024 at 11:43:45AM +0530, Manivannan Sadhasivam wrote: > Bus Master Enable (BME) event that is generated by the Qcom PCIe EP > controller due to host setting the Bus Master Enable bit in the Command > register doesn't have anything to do with the PCIe link. > > Hence, drop the bogus statement. > > Suggested-by: Bjorn Helgaas > Signed-off-by: Manivannan Sadhasivam > --- > drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c > index f6e925d434f6..dcac177b55fb 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c > +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c > @@ -636,7 +636,7 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data) > pcie_ep->link_status = QCOM_PCIE_EP_LINK_DOWN; > pci_epc_linkdown(pci->ep.epc); > } else if (FIELD_GET(PARF_INT_ALL_BME, status)) { > - dev_dbg(dev, "Received Bus Master Enable event. Link is enabled!\n"); > + dev_dbg(dev, "Received Bus Master Enable event\n"); > pcie_ep->link_status = QCOM_PCIE_EP_LINK_ENABLED; > qcom_pcie_ep_icc_update(pcie_ep); > pci_epc_bus_master_enable_notify(pci->ep.epc); > > -- > 2.25.1 > Reviewed-by: Niklas Cassel