From: Johan Hovold <johan@kernel.org>
To: Abel Vesa <abel.vesa@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] phy: qcom: qmp-pcie: Add X1E80100 Gen4 4-lane mode support
Date: Tue, 4 Jun 2024 14:47:30 +0200 [thread overview]
Message-ID: <Zl8M4mPjSjWxrSkN@hovoldconsulting.com> (raw)
In-Reply-To: <Zl8H0KOrfuF91kpZ@linaro.org>
On Tue, Jun 04, 2024 at 03:25:52PM +0300, Abel Vesa wrote:
> On 24-06-03 14:46:12, Johan Hovold wrote:
> > I tried this patch along with the DT changes and the link on the CRD
> > still comes up as 2-lane:
> >
> > qcom-pcie 1bf8000.pci: PCIe Gen.4 x2 link up
> >
> > so something appears to be wrong here. (I noticed the same with your
> > next branch last week.)
> >
> > How did you test this? Does the link actually come up as 4-lane for you?
>
> This is the PHY part. The controller needs some changes as well.
Are you sure? It wasn't needed on sc8280xp (except for updating
num-lanes in DT).
> Yes, as of yet, I'm not able to bring the link up in 4-lanes mode.
Thanks for confirming.
> This however doesn't mean the PHY sequence is incorrect.
Not necessarily, but it means it hasn't been fully tested and that it
could potentially be the reason for the failed x4 link up.
Johan
prev parent reply other threads:[~2024-06-04 12:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 16:06 [PATCH 0/2] phy: qcom: qmp-pcie: Add support for Gen4 4-lane mode for X1E80100 Abel Vesa
2024-05-31 16:06 ` [PATCH 1/2] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document the X1E80100 QMP PCIe PHY Gen4 x4 Abel Vesa
2024-06-01 15:21 ` Krzysztof Kozlowski
2024-06-03 12:43 ` Johan Hovold
2024-06-04 11:00 ` Krzysztof Kozlowski
2024-06-04 11:17 ` Johan Hovold
2024-06-04 11:37 ` Krzysztof Kozlowski
2024-06-04 12:26 ` Johan Hovold
2024-06-04 12:19 ` Abel Vesa
2024-05-31 16:06 ` [PATCH 2/2] phy: qcom: qmp-pcie: Add X1E80100 Gen4 4-lane mode support Abel Vesa
2024-05-31 19:50 ` Dmitry Baryshkov
2024-06-03 12:46 ` Johan Hovold
2024-06-04 12:25 ` Abel Vesa
2024-06-04 12:47 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl8M4mPjSjWxrSkN@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox