From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9094F14601C for ; Tue, 4 Jun 2024 12:45:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717505112; cv=none; b=ZmOTITFkrPStxczuLi7y7pikZKIei28cuuOouTxnnhLwoEpPGbWEbmH04d7tvQhORuSSh+yPPaujphkUgVU3r4En5DXCHtSin6zyMigaXSP7oMdfejByrqVMAx16boddJiQp3slCjg87L34JQ9KQ3IHpQm378GzR5C5J2plMjuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717505112; c=relaxed/simple; bh=FS2meUHyqAFzj3ZwOILxZCEhyOYL5YlmGh67XCjBmN8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rGOj4xgAgUby+FR3Ft5p00Qa0S36BpcW7u5tYFbS8BmJd4igzMj61FPTlOzRjOX2sgxXsJO/5NntpNHnx3TvxleePatQrNyiaqRT2gHmjsidyGtTlWQpxCSX4+BpzyZd01GIfYnqWzttGldI4WHMzIYwcjiW3cMIb0sVf4jyTKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tAOJBFRc; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tAOJBFRc" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52b82d57963so5761320e87.2 for ; Tue, 04 Jun 2024 05:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717505109; x=1718109909; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sTSWP21QZ+eqjBfIIWcv/YErfD1pgnAWKFQYJnk3e7Y=; b=tAOJBFRcY4EiEdYTyDUAVO94+G93of9ZvNso6zHXIUd5Pl9WfuWYHaw9XYhGgckoti /lBwwNiUTZuOZyqu914bqRJ7Yvj77BfVvVIfb1FZSeYB/jh7SH4isRR7/51prRNt9mGu 1QfBZGzFIeRh3MBICIhd6/9XCxMvh4VeQILTLDRGjEifSnlYhLAxrwpdW/PTZsOGPWBb PV83iz54qnbqdPNwBEdLIvoC9E3/M5/MB/Wq4+2Do7Av+pW9HITL3SWp200mhm8MihLH Iw9RBrA2ZAAEKeQMVkaVk3MiB3vMqWQyV6dcaJ8u8iK/Gmf1vxh63G4IloKlHI2F2YNY mq9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717505109; x=1718109909; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sTSWP21QZ+eqjBfIIWcv/YErfD1pgnAWKFQYJnk3e7Y=; b=b2AClw54M3yV+IlAyqeQ3tTT2riWXhLe1PTlkp9rlAKSZLweOi5+CsaEuTa7OJqTzm f/MumFAt8rY3+XYFTazr7fkuYVNBsrqBXmrNp4v9fyaohJiPETQYhMo3feSZqI1NDX5I Bm2XrUql0Oa9+WyPJ/29gPKIPaI8JAqtAx1+s2k1yRU46et339Y40bKZKOTRT3jPIRjq FyGziHg4yc2bPPysmYXGn6LUgQYowitKq0tkaynWRrzN7/xEYld0EpVn6+I7GI7utFoc LBLWpRF4pkIWZ/YYK1Mtj3nn1SjWnnqBmtk1ITInRbnYmXalJTBdXHuwa8RpUisKe0x8 urAQ== X-Forwarded-Encrypted: i=1; AJvYcCXgsh+qcYh75/+msTo4X0oIfg4nOrBqrhnCsr61gvZeC8yUsAaUlOE+6n1V1Ib4e05XGRi3yklyo7XPrDcy94DGNaRW2xT1752EnQsAYQ== X-Gm-Message-State: AOJu0YwTQ1+EGDtrXf4jVwKZhphiMP4eas0tYWhrNtpRwAZBDB+EH4VS CTYXcqzdgo6+0vUQ7y72Hl1CNKkWkSE568uL5QLaG32reO/maoZ3pjqEQTrcvDw= X-Google-Smtp-Source: AGHT+IFm2FI2pRnzHQ9nL48l/MAYYryy+SOdMrgt6P5LxDtGzf5oycvSKJISwo5n1Y/8T5hXK2lPng== X-Received: by 2002:ac2:43cc:0:b0:524:339:4375 with SMTP id 2adb3069b0e04-52b896b69eemr7446350e87.40.1717505108618; Tue, 04 Jun 2024 05:45:08 -0700 (PDT) Received: from linaro.org ([188.27.161.69]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a68519892c8sm587367066b.65.2024.06.04.05.45.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 05:45:08 -0700 (PDT) Date: Tue, 4 Jun 2024 15:45:06 +0300 From: Abel Vesa To: Konrad Dybcio Cc: Johan Hovold , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rajendra Nayak , Sibi Sankar , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] arm64: dts: qcom: x1e80100: Make the PCIe 6a PHY support 4 lanes mode Message-ID: References: <20240531-x1e80100-dts-fixes-pcie6a-v1-0-1573ebcae1e8@linaro.org> <20240531-x1e80100-dts-fixes-pcie6a-v1-2-1573ebcae1e8@linaro.org> <402aa998-8b3c-4c3c-8dcb-f128b6ddac46@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <402aa998-8b3c-4c3c-8dcb-f128b6ddac46@linaro.org> On 24-06-04 14:38:40, Konrad Dybcio wrote: > > > On 6/4/24 14:20, Johan Hovold wrote: > > On Tue, Jun 04, 2024 at 02:00:10PM +0200, Konrad Dybcio wrote: > > > On 6/3/24 14:52, Johan Hovold wrote: > > > > > > As I just mentioned in my reply on the PHY patch, this does not seem to > > > > work on the CRD were the link still come up as 2-lane (also with the > > > > clocks fixed): > > > > > > > > qcom-pcie 1bf8000.pci: PCIe Gen.4 x2 link up > > > > > > > > So something appears to be wrong here or in the PHY changes. > > > > > > Is the device on the other end x4-capable? Or does it not matter in > > > this log line? > > > > Yes, of course. It's the CRD as I wrote above, and you can tell from > > other log entries: > > > > pci 0007:01:00.0: 31.506 Gb/s available PCIe bandwidth, limited by 16.0 GT/s PCIe x2 link at 0007:00:00.0 (capable of 63.012 Gb/s with 16.0 GT/s PCIe x4 link) > > > > lspci and what Windows reports. > Ok, good. I was scared of double-sourcing of parts that are not identical > in spec.. > On my CRD, there is a KBG50ZNS256G. > [1] suggests this wasn't ever achieved.. which makes the cover letter of > this series a bit misleading.. True ... > > What does the TCSR check return? If 0, can you hardcode it to 1 and see if > the link comes up at x4? TCSR check returns 1. But that is not enough. The PCIe controller needs to handles some stuff about margining. See the following patchset. https://lore.kernel.org/linux-pci/20240501163610.8900-3-quic_schintav@quicinc.com/ But even with this, I'm not able to get 4-lanes mode to work (yet). So it must be something else in the controller driver that is needed. IIRC, this is the first Qualcomm platform that would support Gen4 with 4-lanes upstream. Maybe I'm wrong. > > Konrad > > [1] https://lore.kernel.org/all/Zl8H0KOrfuF91kpZ@linaro.org/