From: Mukesh Ojha <quic_mojha@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Komal Bajaj <quic_kbajaj@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: cache: qcom,llcc: Fix QDU1000 description
Date: Wed, 12 Jun 2024 14:51:09 +0530 [thread overview]
Message-ID: <ZmlohTUi6Ppl4k6f@hu-mojha-hyd.qualcomm.com> (raw)
In-Reply-To: <175bd8b0-83b8-45d0-99bd-1e9384fed3f7@kernel.org>
On Wed, Jun 12, 2024 at 09:58:50AM +0200, Krzysztof Kozlowski wrote:
> On 12/06/2024 08:27, Komal Bajaj wrote:
> > QDU1000 DTSI comes with one LLCC0-7 base addresses. Updating
> > dt-bindings accordingly.
> >
> > Fixes: f0f99f371822 ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries")
>
> You are basically reverting without saying this is a revert and without
> explanation.
>
> What's happening with QDU1000? Why it is such a mess that DTS was
> totally not matching bindings drivers and now suddenly we need to revert
> commits?
I think, this happened because of the refactoring happened in LLCC driver
and at the same time QDU1000 device tree change picked while other SoCs
change was made like
e.g
https://lore.kernel.org/r/20230314080443.64635-11-manivannan.sadhasivam@linaro.org
https://lore.kernel.org/r/20230517-topic-kailua-llcc-v1-2-d57bd860c43e@linaro.org
However, this change missed for QDU1000, later f0f99f371822 ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries")
happened and now realized the driver does not work anymore with current
binding and hence fixing was required.
-Mukesh
prev parent reply other threads:[~2024-06-12 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 6:27 [PATCH 0/2] qdu1000: Fix LLCC reg property Komal Bajaj
2024-06-12 6:27 ` [PATCH 1/2] arm64: dts: qcom: " Komal Bajaj
2024-06-12 9:02 ` Mukesh Ojha
2024-06-12 6:27 ` [PATCH 2/2] dt-bindings: cache: qcom,llcc: Fix QDU1000 description Komal Bajaj
2024-06-12 7:58 ` Krzysztof Kozlowski
2024-06-12 9:21 ` Mukesh Ojha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmlohTUi6Ppl4k6f@hu-mojha-hyd.qualcomm.com \
--to=quic_mojha@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kbajaj@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox