Re: [PATCH net-next 4/8] net: phy: aquantia: add support for aqr115c

Andrew Lunn
2024-06-19T19:19:56Z

> case MDIO_PHYXS_VEND_IF_STATUS_TYPE_OCSGMII:
> - phydev->interface = PHY_INTERFACE_MODE_2500BASEX;
> + phydev->interface = PHY_INTERFACE_MODE_OCSGMII;

That looks interesting. I wounder what will break.

> break;
> default:
> phydev->interface = PHY_INTERFACE_MODE_NA;
> @@ -721,6 +721,18 @@ static int aqr113c_config_init(struct phy_device *phydev)
> return aqr107_fill_interface_modes(phydev);
> }
>
> +static int aqr115c_config_init(struct phy_device *phydev)
> +{
> + /* Check that the PHY interface type is compatible */
> + if (phydev->interface != PHY_INTERFACE_MODE_SGMII &&
> + phydev->interface != PHY_INTERFACE_MODE_OCSGMII)
> + return -ENODEV;

Does it support 2500BaseX?

Andrew