Re: [PATCH net-next 4/8] net: phy: aquantia: add support for aqr115c

Andrew Lunn
2024-06-19T21:25:11Z

> case MDIO_PHYXS_VEND_IF_STATUS_TYPE_OCSGMII:
> - phydev->interface = PHY_INTERFACE_MODE_2500BASEX;
> + phydev->interface = PHY_INTERFACE_MODE_OCSGMII;
> break;

O.K. Given Russells reply, what happens if you skip this hunk, don't
add PHY_INTERFACE_MODE_OCSGMII but use PHY_INTERFACE_MODE_2500BASEX,
and change the MAC driver as needed. Given this here, it seems likely
somebody else is using MDIO_PHYXS_VEND_IF_STATUS_TYPE_OCSGMII as
PHY_INTERFACE_MODE_2500BASEX, so i expect it will work.

Adding PHY_INTERFACE_MODE_OCSGMII is a UAPI addition, since it becomes
possible to pass it in phy-mode in DT. That means, it is hard to
remove later, if Russell ever finds the time to finish his patches,
and PHY_INTERFACE_MODE_OCSGMII is not needed. So if we can avoid
adding it, we should.

Andrew