From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FCC5256E for ; Mon, 24 Jun 2024 09:33:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719221629; cv=none; b=oE+wXBTzpkaELeAW2sZQoGsPDTWcbhxaF023TYAXTRk3itvyP65wyigUTvgydgsZSZstFARlgWLo8hODe1VdpF50YlBlvuElpenmMXuc1wklGm8oUx3kwx/1MpWA7dNbp3WJXaJ55ax2tyrFB8Oc2J6Ttd7LGLwu/NMAwFNy0BQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719221629; c=relaxed/simple; bh=/KL/NdBDG58xCIPAw4YwdMeg/5iy22kVY2U90t04DA8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fG3VzUAmhRIKojK3uS5o/8HPohSVUm5pgv5WvdM3fA9lNLhf7eIZtwILwMa1TtOI5vWV4qiAdO4wjL3YQnJEUO1FXH/iP5zdpPoyiFt25gg0dE4Q7mT5Jy0nENWwDmnQypFpYibUtuH/FtADxreN87PK9JFZ9Q6d8W/0MveX6t4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch; spf=none smtp.mailfrom=ffwll.ch; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b=iJy3SyWT; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="iJy3SyWT" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3660944544eso234598f8f.3 for ; Mon, 24 Jun 2024 02:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1719221626; x=1719826426; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=hDecevrNwUO63hAzBHMfL3jldrZsRCPWB7PKUAe6PW4=; b=iJy3SyWTvK5GK2A6Nr6YdO4jXj+vSOuOiimH1UrurVIIUz01VnrJfOe5IdPD0rWzCa jXJiSqZuhjzfmMnUOaudSiBAzL8/XyEMC6fjiBRyzQg3+efsizwg1TtuB36R0c1FufHN ZxwCBub7McDu9+h4ME7w0CGrMudV9Z4lywclg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719221626; x=1719826426; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hDecevrNwUO63hAzBHMfL3jldrZsRCPWB7PKUAe6PW4=; b=PQt7BRfZQIsap9FTCZFBhrhIhzBn2golsBtkHmgPiTWeZqA0BtIgDZgwZW/Iv8EeLx pdGn6kDAJ/u026wU9H/4HQpBjdCWoWv9AhLm/uuMI3Q0GB2dJf0q9C1ISSpXLOrF8ACd ZYoFdEpBac/XAmZG9L2ig+DY+hYNm4wKwbTsBx4b0vMgKDGlpwW6yqZTxnKlmfw5Ctm2 4mJVnXMweYByetqy4TjrVi5Nc8VvkNRkYeEl/MopGnZJ1A4F48ZbYiBkYmp6BI6q/I5Q iR6/lIV+6u19vjqfh9zKUgHGk6riKp/bXXNh023oSXbji6mr190lDgcAK6m3Qze88Sbl RMlA== X-Forwarded-Encrypted: i=1; AJvYcCVWJ7wYLUfl6AQFXTvQXYO1hG9U+/9yKXlXBtF7zuYPN2KJEbMpu4KMHiX12WfVfynysiBtb3fPghdl6/MfnyUjUklMDvx0w2ST5ez4IA== X-Gm-Message-State: AOJu0Yw/cl4HMuC+DdO8yi+SctsAr0VQU8r1J7WhXHW+rE/S8XBHhznl DPMLRhJ1VrpEXh2L+PgGYTptwAZote68nD72diO0dsA00lFqEbQdWHgrintRqR0= X-Google-Smtp-Source: AGHT+IFmDBOhp59HDggw1pz7CehJXLtxtOoh3bEUePIFnDfBhsEsaT5adH0/nPk85Q2FcM5IFWiknA== X-Received: by 2002:a5d:5983:0:b0:35f:2929:8460 with SMTP id ffacd0b85a97d-366dfa2d903mr4504328f8f.3.1719221626371; Mon, 24 Jun 2024 02:33:46 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-366389b8634sm9593317f8f.34.2024.06.24.02.33.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 02:33:45 -0700 (PDT) Date: Mon, 24 Jun 2024 11:33:43 +0200 From: Daniel Vetter To: Bjorn Andersson Cc: Jeffrey Hugo , Dmitry Baryshkov , Ekansh Gupta , Oded Gabbay , srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, Dave Airlie Subject: Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/ Message-ID: Mail-Followup-To: Bjorn Andersson , Jeffrey Hugo , Dmitry Baryshkov , Ekansh Gupta , Oded Gabbay , srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, Dave Airlie References: <20240612064731.25651-1-quic_ekangupt@quicinc.com> <6f59552d-d7a3-5e05-3465-e707c1b7eaf2@quicinc.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 6.8.9-amd64 On Sun, Jun 23, 2024 at 03:19:17PM -0500, Bjorn Andersson wrote: > On Fri, Jun 21, 2024 at 05:52:32PM GMT, Daniel Vetter wrote: > > On Fri, Jun 21, 2024 at 09:40:09AM -0600, Jeffrey Hugo wrote: > > > On 6/21/2024 5:19 AM, Dmitry Baryshkov wrote: > > > > On Fri, 21 Jun 2024 at 09:19, Bjorn Andersson wrote: > > > > > > > > > > On Wed, Jun 12, 2024 at 09:28:39PM GMT, Dmitry Baryshkov wrote: > > > > > > On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekansh Gupta wrote: > > > > > > > Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned > > > > > > > to be added for PD notifications and other missing features. Adding > > > > > > > and maintaining new files from within fastrpc directory would be easy. > > > > > > > > > > > > > > Example of feature that is being planned to be introduced in a new C > > > > > > > file: > > > > > > > https://lore.kernel.org/all/20240606165939.12950-6-quic_ekangupt@quicinc.com/ > > > > > > > > > > > > > > Signed-off-by: Ekansh Gupta > > > > > > > --- > > > > > > > MAINTAINERS | 2 +- > > > > > > > drivers/misc/Kconfig | 13 +------------ > > > > > > > drivers/misc/Makefile | 2 +- > > > > > > > drivers/misc/fastrpc/Kconfig | 16 ++++++++++++++++ > > > > > > > drivers/misc/fastrpc/Makefile | 2 ++ > > > > > > > drivers/misc/{ => fastrpc}/fastrpc.c | 0 > > > > > > > 6 files changed, 21 insertions(+), 14 deletions(-) > > > > > > > create mode 100644 drivers/misc/fastrpc/Kconfig > > > > > > > create mode 100644 drivers/misc/fastrpc/Makefile > > > > > > > rename drivers/misc/{ => fastrpc}/fastrpc.c (100%) > > > > > > > > > > > > Please consider whether it makes sense to move to drivers/accel instead > > > > > > (and possibly writing a better Kconfig entry, specifying that the driver > > > > > > is to be used to offload execution to the DSP). > > > > > > > > > > > > > > > > Wouldn't this come with the expectation of following the ABIs of > > > > > drivers/accel and thereby breaking userspace? > > > > > > > > As I wrote earlier, that depends on the accel/ maintainers decision, > > > > whether it's acceptable to have non-DRM_ACCEL code underneath. > > > > But at least I'd try doing that on the grounds of keeping the code at > > > > the proper place in the drivers/ tree, raising awareness of the > > > > FastRPC, etc. > > > > For example current fastrpc driver bypasses dri-devel reviews, while > > > > if I remember correctly, at some point it was suggested that all > > > > dma-buf-handling drivers should also notify the dri-devel ML. > > If the agreement is that dma-buf-handling drivers must get reviews from > dri-devel, then let's document that in MAINTAINERS and agree with the > maintainer. About 5 years ahead of you here with 78baee8d3b97 ("MAINTAINERS: Match on dma_buf|fence|resv anywhere"). Cheers, Sima -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch