From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 987C92B9D4; Mon, 8 Jul 2024 10:10:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720433452; cv=none; b=K39qaoxDieAuW3089OXHhY3kALJ+FCKo5mY0mktEmeRR0+wGux+r4HSXuIgqth4zZXGVPr0bOc+UeB5GCGYJAl2Upd8vnNmmZFUR8Qre3B6PAeQZofHHkKGFwtWF8MWj8ei+CE7wAQtSFHbfIYgkmP+J9mJxis9S+0pdwJ6u7Ug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720433452; c=relaxed/simple; bh=fqiP3AQMKTWs3ovIeScUvdFRFnjcQsZI6ZDFVitj3Oc=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=huhSrVVruuFY8SlikPtQfsfWiIrJx5bsVtgJIBrUwx+pUh3SPE9IhiuQLeXRKH6ukCuSOk2h2ZP/5GaCX/Zk+YCWt7qhWx6g6e3qhpZVZ/lXQzZ4pwryPhSDYZyePhbgWf1m2r2WZ8rC2yA0BR1GEIFCoHXOihdx8BPMbSSLMns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=BJ5BM8U8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="BJ5BM8U8" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 467LuFIE030239; Mon, 8 Jul 2024 10:10:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UpNzBQwqjwDcwCazNArc7AjwwxbO4uTDezZTvIDzncw=; b=BJ5BM8U8Plh5nzXG ANpjdLjcfnLO70X8SvYF3XRVdc8hjeuj3Vu/uras4ybICj8S0Ek5+1iKt6jBZQBF 2TggGtwhu1Y6pzCF/oVlE7JeeiwAQtJqTqDZkjBO9U/nb875Ka7bWB5320DDuXyC qHsRGAnjNL2v73igMaaP9+gB6jDkISxnDQGH8RK86Hh+abHN3hgidT8BO2y01NXT uqYcrWoe9czoK2KU+8FMbUpI6f7y5SzZYhEdZzFwWQ5/7f+gLodWT7wTWPcvaJvA RM0Wa2in3nW/8YMuN4Y4QRO5ZNttn5jKQcU9gDx5m/yRqZsDLXplLEMoDTUrdSh0 h+Hw6w== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 406x5138jc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Jul 2024 10:10:39 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA04.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 468AAc2L010884 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 8 Jul 2024 10:10:38 GMT Received: from jiegan-gv.ap.qualcomm.com (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 8 Jul 2024 03:10:32 -0700 Date: Mon, 8 Jul 2024 18:10:28 +0800 From: JieGan To: Suzuki K Poulose CC: Mathieu Poirier , Alexander Shishkin , Mike Leach , "Rob Herring" , Krzysztof Kozlowski , James Clark , Jinlong Mao , Leo Yan , , , , , Tingwei Zhang , Yuanfang Zhang , "Tao Zhang" , Trilok Soni , "Song Chai" , Subject: Re: [PATCH v2 2/4] dt-bindings: arm: Add binding document for Coresight Control Unit device. Message-ID: References: <20240705090049.1656986-1-quic_jiegan@quicinc.com> <20240705090049.1656986-3-quic_jiegan@quicinc.com> <208b3861-6898-4506-9152-c9d770ef1555@arm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <208b3861-6898-4506-9152-c9d770ef1555@arm.com> X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 9qnswLDy7VUKYSIFYm9bovppNP874OkJ X-Proofpoint-ORIG-GUID: 9qnswLDy7VUKYSIFYm9bovppNP874OkJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-08_05,2024-07-05_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=1 suspectscore=0 impostorscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2407080079 On Mon, Jul 08, 2024 at 10:41:55AM +0100, Suzuki K Poulose wrote: > On 05/07/2024 10:00, Jie Gan wrote: > > Add binding document for Coresight Control Unit device. > > nit: This is again too generic ? corsight-tmc-control-unit ? After all > thats what it is and not a *generic* coresight control unit ? > coresight-tmc-control-unit is much better. We will check it. > > > > Signed-off-by: Jie Gan > > --- > > .../bindings/arm/qcom,coresight-ccu.yaml | 87 +++++++++++++++++++ > > 1 file changed, 87 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/qcom,coresight-ccu.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-ccu.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-ccu.yaml > > new file mode 100644 > > index 000000000000..9bb8ced393a7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-ccu.yaml > > @@ -0,0 +1,87 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/arm/qcom,coresight-ccu.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: CoreSight Control Unit > > + > > +maintainers: > > + - Yuanfang Zhang > > + - Mao Jinlong > > + - Jie Gan > > + > > +description: > > + The Coresight Control unit controls various Coresight behaviors. > > + Used to enable/disable ETR’s data filter function based on trace ID. > > + > > +properties: > > + compatible: > > + const: qcom,coresight-ccu > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + items: > > + - const: apb_pclk > > + > > + reg-names: > > + items: > > + - const: ccu-base > > + > > + in-ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + unevaluatedProperties: > > + patternProperties: > > + '^port(@[0-7])?$': > > + description: Input connections from CoreSight Trace bus > > + $ref: /schemas/graph.yaml#/properties/port > > + > > + properties: > > + qcom,ccu-atid-offset: > > Why do we need this atid offset ? Couldn't this be mapped to the "port" > number ? > > e.g, input-port 0 on CCU => Offset x > input-port 1 on CCU => (Offset x + Size of 1 region) If the first ATID offset remains constant, it appears to be feasible. We will consider the possibility of this solution. > > I believe I mentioned this in the previous posting too ? Yes, you mentioned before. I moved it from TMC filed to CCU filed. > > Suzuki >