From: Johan Hovold <johan@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hansverk@cisco.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Milen Mitkov <quic_mmitkov@quicinc.com>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>
Subject: Re: [PATCH 2/2] media: qcom: camss: Fix ordering of pm_runtime_enable
Date: Mon, 15 Jul 2024 09:46:14 +0200 [thread overview]
Message-ID: <ZpTTxk_7hBbFLTTp@hovoldconsulting.com> (raw)
In-Reply-To: <20240714-linux-next-24-07-13-camss-fixes-v1-2-8f8954bc8c85@linaro.org>
On Sun, Jul 14, 2024 at 11:53:59PM +0100, Bryan O'Donoghue wrote:
> pm_runtime_enable() should happen prior to vfe_get() since vfe_get() calls
> pm_runtime_resume_and_get().
Again, please describe how this manifest itself to users. I see
occasional:
qcom-camss ac5a000.camss: Failed to power up pipeline: -13
on boot.
> This is a basic race condition that doesn't show up for most users so is
> not widely reported. If you blacklist qcom-camss in modules.d and then
> subsequently modprobe the module post-boot it is possible to reliably show
> this error up.
>
> Fixes: 02afa816dbbf ("media: camss: Add basic runtime PM support")
Missing CC-stable here too.
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reported-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/lkml/ZoVNHOTI0PKMNt4_@hovoldconsulting.com/
Tested-by: Johan Hovold <johan+linaro@kernel.org>
Johan
prev parent reply other threads:[~2024-07-15 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-14 22:53 [PATCH 0/2] media: qcom: camss: Fix two CAMSS bugs found by dogfooding with SoftISP Bryan O'Donoghue
2024-07-14 22:53 ` [PATCH 1/2] media: qcom: camss: Remove use_count guard in stop_streaming Bryan O'Donoghue
2024-07-15 7:43 ` Johan Hovold
2024-07-14 22:53 ` [PATCH 2/2] media: qcom: camss: Fix ordering of pm_runtime_enable Bryan O'Donoghue
2024-07-15 7:46 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpTTxk_7hBbFLTTp@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hansverk@cisco.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=johan+linaro@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_mmitkov@quicinc.com \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox