Re: [PATCH v4 05/10] pmdomain: qcom: rpmpd: Add IPQ9574 power domains

[Varadarajan Narayanan <quic_varada@quicinc.com>]

On Tue, Jul 09, 2024 at 11:52:19AM +0200, Konrad Dybcio wrote:
> On 3.07.2024 11:16 AM, Varadarajan Narayanan wrote:
> > From: Praveenkumar I <quic_ipkumar@quicinc.com>
> >
> > Add the APC power domain definitions used in IPQ9574.
> >
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> > ---
> > v4: Add Reviewed-by: Dmitry Baryshkov
> > v3: Fix patch author
> > v2: Fix Signed-off-by order
> > ---
> >  drivers/pmdomain/qcom/rpmpd.c | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >
> > diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c
> > index 5e6280b4cf70..947d6a9c3897 100644
> > --- a/drivers/pmdomain/qcom/rpmpd.c
> > +++ b/drivers/pmdomain/qcom/rpmpd.c
> > @@ -38,6 +38,7 @@ static struct qcom_smd_rpm *rpmpd_smd_rpm;
> >  #define KEY_FLOOR_CORNER	0x636676   /* vfc */
> >  #define KEY_FLOOR_LEVEL		0x6c6676   /* vfl */
> >  #define KEY_LEVEL		0x6c766c76 /* vlvl */
> > +#define RPM_KEY_UV		0x00007675 /* "uv" */
>
> The "uv" key is handled in qcom_smd-regulator.c.. I'm assuming on this
> platform, it accepts level idx instead of the regulator properties
> and this is intentional?

IPQ9574 RPM accepts regulator properties (uv) and not the level idx.
Hence added the "uv" key in the rpmpd.c

Thanks
Praveen/Varada