From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D582D1DC472 for ; Fri, 2 Aug 2024 10:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722594410; cv=none; b=FBz3ESTsScuugzuDPrIyrS6v+GKqZuYqo6TLzeNhJ90iVhnEPwDpFrxvqi6JJKwo8jOEhkKfLHRx3hQn6frP2z1C5qteeUcit4pa3bpJ3If0b9dHo4GyUvQqsUNB6vY0lof9Pa3OR0yxY0G0YOXdgmX0eojB6znLIBG2DIL6BAo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722594410; c=relaxed/simple; bh=88EsHwdU6Y+t2Ieew7M7TZT/MUEah4z8QXOdX5NNz4Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YVSfA22EKo2Cf5jJEFOmwehT4JV+mSCzWshb0PXzsc0RXDSnbZQWg/Ca8tbT40X6GEUwtJ20DT1MlWeO7SxKYHLPghzJ4EnJ/xDw8+q/wpL0fTxfgrI/IOaF0iM+Bxuhvpeahs/sbpZjeSZnT6mOnnpfDSEfiWbHmldxKnvs2Wk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Dus9GJwl; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Dus9GJwl" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a7d26c2297eso993292366b.2 for ; Fri, 02 Aug 2024 03:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722594406; x=1723199206; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=MZClsDIezKC5v39tjWHXTTLMvzNHfVoW5l/xW5hpIwo=; b=Dus9GJwlp1+Ifbn9sgMQy96Xn8bIW6khRhjvZX/HO5Z6hImwMkah+DUPI3WDMsJAbS 7wfUsrs7aEXMkaPx/UNoHRL8DJ5g3nLhOCtt+HtqJkgHWwUgaut7pcHdVzjeUYZRr8Le tskPPufz4ojx6eey900TCDqzuQGnrt41vuwtfQc6P56ldGAji1E8cp6wvmIkZMYIH+s/ BlLbxVOPZl9YQeja6kZfxHCOcqrv36kpxTthIcFYhYTQPmzbqj3joy0P06irL5pqRASF 5hp4eBa3SSL86gfkGKyQxQ3AfjNkpn3iYx/vAROWM7zpdYkrMTehcR1HhI50EZWRGsbq m/zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722594406; x=1723199206; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MZClsDIezKC5v39tjWHXTTLMvzNHfVoW5l/xW5hpIwo=; b=u/AszDIuOAhQxEGbYwRK1CzqDN0yrHndLv3bTuCi4xBO6vTNSV1dHdilmjmJbxgdz5 SSgPoYMjxSEgh8BPmaA7rYPNXKdqUQXw2Jb1QpQtiMdE5fBTs4a+BZvZWGlA7fPaXgTa MjMVJGuQ3IbiARNfBtTfr/tJnksbE7RFnZIk53uS0gQBBdhysUKdGZiFqWSDpEjYrXZA Ma7zC/+npwzW0hiBhKVQkA5WOB/Xs1T3WvhMS4KaSMGkLM6xEKyTmJgmZj/GS+9NbH9T vB6LZNumTK+fX8O/PoaV+DnlaBRRn0W3//UgD3u7qXi0Fb0zBnRxJSFkY0wfpWxPGlEP wyXw== X-Gm-Message-State: AOJu0Yy3jY1vyR+gKJNGo8v3x7JamiV6pD3eNyavsqgH3UtN6KHCyR3U YwYO8S7GX8LIzAwAjNLcQCBGgI2kU17GzWajgk5r2amQkes5JIcvT6yzr5CRLpM= X-Google-Smtp-Source: AGHT+IFUaE5rrsfA9b5/ZoGfuC8RNmYZJr/mp6vmwHEmr3g3yDGqsB5UvpfbLaTZwfHnbynPxGVM1A== X-Received: by 2002:a17:906:730f:b0:a6f:501d:c224 with SMTP id a640c23a62f3a-a7dc5100bbcmr210051566b.57.1722594406014; Fri, 02 Aug 2024 03:26:46 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff1f:b280:780c:5cd0:3813:8ce9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9ec4a8dsm81645566b.190.2024.08.02.03.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Aug 2024 03:26:45 -0700 (PDT) Date: Fri, 2 Aug 2024 12:26:40 +0200 From: Stephan Gerhold To: Rob Clark Cc: linux-arm-msm@vger.kernel.org, Abel Vesa , Krzysztof Kozlowski , Rob Clark , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , Srinivas Kandagatla Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: x1e80100-yoga: Update panel bindings Message-ID: References: <20240729205726.7923-1-robdclark@gmail.com> <20240729205726.7923-2-robdclark@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jul 30, 2024 at 07:26:27AM -0700, Rob Clark wrote: > On Tue, Jul 30, 2024 at 3:00 AM Stephan Gerhold > wrote: > > > > On Mon, Jul 29, 2024 at 01:57:25PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Use the correct panel compatible, and wire up enable-gpio. It is wired > > > up in the same way as the x1e80100-crd. > > > > > > Signed-off-by: Rob Clark > > > Reviewed-by: Abel Vesa > > > --- > > > Note that the power-source differs from the CRD. Figured that out by > > > diffing $debugfs/gpio. > > > > > > .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 17 +++++++++++++++-- > > > 1 file changed, 15 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > > > index 70977e9fa266..6f8d52c368a4 100644 > > > --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > > > +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > > > [...] > > > @@ -669,6 +672,16 @@ &pcie6a_phy { > > > status = "okay"; > > > }; > > > > > > +&pmc8380_3_gpios { > > > + edp_bl_en: edp-bl-en-state { > > > + pins = "gpio4"; > > > + function = "normal"; > > > + power-source = <0>; /* 1.8V */ > > > > Hm, are you sure the firmware sets it like this? > > > > power-source = <0> is typically VPH, i.e. the main battery supply > > voltage or similar. This will definitely be higher than 1.8V. It seems a > > bit odd to use a variable voltage source for a GPIO... > > :shrug: > > Board level stuff is a bit outside my area of expertise, but it's what > made /sys/kernel/debug/gpio match for gpiochip3 gpio4 and it's what > made the panel work. Using <1> resulted in a black screen. > > AFAIU Srini has a yoga 7x as well, and perhaps knows how to read ACPI > better than I do, so maybe he can double check. > It looks like you're right, I think ACPI also configures power-source = <0>. Can you just remove the 1.8V comment then? I'm pretty sure it's not 1.8V. Thanks, Stephan