From: Johan Hovold <johan@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jagadeesh Kona <quic_jkona@quicinc.com>,
Taniya Das <quic_tdas@quicinc.com>,
Abel Vesa <abel.vesa@linaro.org>,
Konrad Dybcio <konradybcio@kernel.org>
Subject: Re: [PATCH] clk: qcom: videocc-sm8350: use HW_CTRL_TRIGGER for vcodec GDSCs
Date: Wed, 16 Oct 2024 09:39:49 +0200 [thread overview]
Message-ID: <Zw9txV7gmWE5D8BE@hovoldconsulting.com> (raw)
In-Reply-To: <20240901093024.18841-1-johan+linaro@kernel.org>
On Sun, Sep 01, 2024 at 11:30:24AM +0200, Johan Hovold wrote:
> A recent change in the venus driver results in a stuck clock on the
> Lenovo ThinkPad X13s, for example, when streaming video in firefox:
>
> video_cc_mvs0_clk status stuck at 'off'
> WARNING: CPU: 6 PID: 2885 at drivers/clk/qcom/clk-branch.c:87 clk_branch_wait+0x144/0x15c
> ...
> Call trace:
> clk_branch_wait+0x144/0x15c
> clk_branch2_enable+0x30/0x40
> clk_core_enable+0xd8/0x29c
> clk_enable+0x2c/0x4c
> vcodec_clks_enable.isra.0+0x94/0xd8 [venus_core]
> coreid_power_v4+0x464/0x628 [venus_core]
> vdec_start_streaming+0xc4/0x510 [venus_dec]
> vb2_start_streaming+0x6c/0x180 [videobuf2_common]
> vb2_core_streamon+0x120/0x1dc [videobuf2_common]
> vb2_streamon+0x1c/0x6c [videobuf2_v4l2]
> v4l2_m2m_ioctl_streamon+0x30/0x80 [v4l2_mem2mem]
> v4l_streamon+0x24/0x30 [videodev]
>
> using the out-of-tree sm8350/sc8280xp venus support. [1]
>
> Update also the sm8350/sc8280xp GDSC definitions so that the hw control
> mode can be changed at runtime as the venus driver now requires.
>
> Fixes: ec9a652e5149 ("venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode on V6")
> Link: https://lore.kernel.org/lkml/20230731-topic-8280_venus-v1-0-8c8bbe1983a5@linaro.org/ # [1]
> Cc: Jagadeesh Kona <quic_jkona@quicinc.com>
> Cc: Taniya Das <quic_tdas@quicinc.com>
> Cc: Abel Vesa <abel.vesa@linaro.org>
> Cc: Konrad Dybcio <konradybcio@kernel.org>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
This one did not make it into 6.11 and should now be backported as well:
Cc: stable@vger.kernel.org # 6.11
Bjorn, can you pick it up for 6.12-rc?
Johan
next prev parent reply other threads:[~2024-10-16 7:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-01 9:30 [PATCH] clk: qcom: videocc-sm8350: use HW_CTRL_TRIGGER for vcodec GDSCs Johan Hovold
2024-09-01 10:49 ` Steev Klimaszewski
2024-10-16 7:39 ` Johan Hovold [this message]
2024-10-16 20:42 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw9txV7gmWE5D8BE@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox