From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA9D3199FB9; Fri, 11 Oct 2024 06:36:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728628589; cv=none; b=TuGUr4Bx61AAc6AUU3OBgKSqTr3lNdjWpz9iUFTebXjNkO1WBk7U2WuqF3M7ZV6SSrCfTc7RD2mtQ0kWtXsLxQzEnJ0iyTFAWNAP4QJl7inG8fM3uDNzerkGxslKKEZxrA7Y+L4k82dSPATTOdE2R2TokqWe9zN+sNkDJQSqoNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728628589; c=relaxed/simple; bh=CrQYK7ks5t8HLoC1QvVn/wgqIQOWlmWPGK+YGoKdXoI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YX0LZheEpdy3ooRTMAkB/GzS0R2ePeKgghRHDdOlm6IQOKbgG9hXVQ1b8C+0PV3YhmyU8Qmhk8dE34h1rcJ1oacE42WH74JfqmHGfkhvPzo5LRVBOIKnxiqCA0Fktb8gqrT061u2OBE+RJq51tD7yzh4OHtELV1DFL3M7cj6Ppw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H1l68gF8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H1l68gF8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B641C4CEC3; Fri, 11 Oct 2024 06:36:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728628589; bh=CrQYK7ks5t8HLoC1QvVn/wgqIQOWlmWPGK+YGoKdXoI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H1l68gF8uaLCkomQMUYCPsFACWAvaFjI1KuhNMvNuVeRMlMAgkaldfZMZ2qY4kCjL O5k+WKJMlogN63gf2bxt6kveSUlAqQSamVVR3+QzuZVC131RY1ClI6h7Wn2PRc5lNI MOgtk4p35pS8+AdUqEraWOLaWoj2Kr1YJzvLDH1MPzEEXVP5YGsMbuh82ouUYKsREH HMnS4cemDROKnXbklRd+fPP+GrTKUkcXnjPqu0sJOMwPhLYcPmHk6AkK8jUq1R9wYQ kdBI4OY4QMMExtWfDz1mQeA37w16MR67OD4rOY+fOit4inBg3mm9KoHJq87Y/dUDJ0 mkCZ2qk77hThg== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1sz9GM-000000002Vt-47wt; Fri, 11 Oct 2024 08:36:35 +0200 Date: Fri, 11 Oct 2024 08:36:34 +0200 From: Johan Hovold To: =?utf-8?B?SsOpcsO0bWU=?= de Bretagne Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Johan Hovold , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maximilian Luz , Krzysztof Kozlowski Subject: Re: [PATCH v2 5/5] arm64: dts: qcom: sc8280xp: Add Microsoft Surface Pro 9 5G Message-ID: References: <20240908223505.21011-1-jerome.debretagne@gmail.com> <20240908223505.21011-6-jerome.debretagne@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Oct 10, 2024 at 11:17:35PM +0200, Jérôme de Bretagne wrote: > Le jeu. 10 oct. 2024 à 10:52, Johan Hovold a écrit : > > On Mon, Sep 09, 2024 at 12:35:05AM +0200, Jérôme de Bretagne wrote: > > You mention it in the commit message, but since a lot of this is copied > > from the X13s (and CRD) devicetrees you should probably make that clear > > here as well and include the relevant copyright notices. For example by > > adding: > > > > Based on ... > > > > Copyright ... > Thank you for the suggestion, so it would look like this? You can still keep your copyright notice first, and I meant something like: /* * Microsoft Surface Pro 9 5G devicetree * * Copyright (c) 2024, Jérôme de Bretagne <...> * * Based on sc8280xp-crd.dts and sc8280xp-lenovo-thinkpad-x13s.dts: * * Copyright (c) 2021, The Linux Foundation. All rights reserved. * Copyright (c) 2022, Linaro Limited */ > How do you want me to add this to the patchset? > Should I send a separate fix-up patch? > Or should I create a newer v3 patchset? Ah, sorry, I missed that Bjorn had already picked this one up. Either leave it as is, or send an incremental (fix-up) patch. Johan