From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Abel Vesa <abel.vesa@linaro.org>,
Stephan Gerhold <stephan.gerhold@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: x1e80100-crd: describe HID supplies
Date: Fri, 1 Nov 2024 08:33:17 +0100 [thread overview]
Message-ID: <ZySEPXOxgZj-s75F@hovoldconsulting.com> (raw)
In-Reply-To: <304b909d-bf2d-446c-acc9-e65b94627468@oss.qualcomm.com>
On Thu, Oct 31, 2024 at 10:00:20PM +0100, Konrad Dybcio wrote:
> On 29.10.2024 8:52 AM, Johan Hovold wrote:
> > + vreg_misc_3p3: regulator-misc-3p3 {
> > + compatible = "regulator-fixed";
> > +
> > + regulator-name = "VREG_MISC_3P3";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > +
> > + gpio = <&pm8550ve_8_gpios 6 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&misc_3p3_reg_en>;
>
> property-n
> property-names
>
> for consistency, please
Sure, will switch these to match the new style that this driver mostly
follows (but as we've discussed before, the traditional style that most
dt still use for pinctrl is what I used above).
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Thanks for reviewing.
Johan
next prev parent reply other threads:[~2024-11-01 7:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 7:52 [PATCH v2] arm64: dts: x1e80100-crd: describe HID supplies Johan Hovold
2024-10-31 21:00 ` Konrad Dybcio
2024-11-01 7:33 ` Johan Hovold [this message]
2024-11-04 4:13 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZySEPXOxgZj-s75F@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stephan.gerhold@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox