From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] firmware: qcom: scm: rework QSEECOM allowlist
Date: Mon, 4 Nov 2024 13:15:41 +0100 [thread overview]
Message-ID: <Zyi67e5Os0RhXNjn@hovoldconsulting.com> (raw)
In-Reply-To: <02171841-acd3-4f26-987d-1376caf11481@oss.qualcomm.com>
On Mon, Nov 04, 2024 at 12:23:57PM +0100, Konrad Dybcio wrote:
> On 3.11.2024 4:37 PM, Dmitry Baryshkov wrote:
> > static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = {
> > - { .compatible = "dell,xps13-9345" },
> > - { .compatible = "lenovo,flex-5g" },
> > - { .compatible = "lenovo,thinkpad-t14s" },
> > - { .compatible = "lenovo,thinkpad-x13s", },
> > - { .compatible = "lenovo,yoga-slim7x" },
> > - { .compatible = "microsoft,arcata", },
> > - { .compatible = "microsoft,romulus13", },
> > - { .compatible = "microsoft,romulus15", },
> > - { .compatible = "qcom,sc8180x-primus" },
> > - { .compatible = "qcom,x1e80100-crd" },
> > - { .compatible = "qcom,x1e80100-qcp" },
> > + { .compatible = "qcom,sc8180x", .data = (void *)true },
> > + { .compatible = "qcom,sc8280xp", .data = (void *)true },
> > + { .compatible = "qcom,x1e80100", .data = (void *)true },
> > { }
> > };
>
> + Steev I think you had some unhappy machine
>
> And maybe 8180 Primus?
I have a sc8280xp crd here where variables can only be read, not stored
(e.g. similar to the Lenovo Yoga C630). In it's current configuration
the machine boots from UFS and this could possibly be related to how it
has been provisioned, but this is the reason why "qcom,sc8280xp-crd" is
not already in the above list.
Johan
next prev parent reply other threads:[~2024-11-04 12:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-03 15:37 [PATCH 0/2] firmware: scm: rework allowlist to be more scalable Dmitry Baryshkov
2024-11-03 15:37 ` [PATCH 1/2] firmware: qcom: scm: add modparam to control QSEECOM enablement Dmitry Baryshkov
2024-11-04 9:38 ` Konrad Dybcio
2024-11-03 15:37 ` [PATCH 2/2] firmware: qcom: scm: rework QSEECOM allowlist Dmitry Baryshkov
2024-11-04 11:23 ` Konrad Dybcio
2024-11-04 11:34 ` Dmitry Baryshkov
2024-11-04 13:31 ` Konrad Dybcio
2024-11-04 12:15 ` Johan Hovold [this message]
2024-11-04 19:43 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zyi67e5Os0RhXNjn@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox