From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F7D916DEB5; Wed, 20 Nov 2024 08:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732091978; cv=none; b=Eyp48xyKphVF4hfFJjoHchSef9UBRUApLZ33AuvjQbwpIQ16Q48rPz8ubwOSkRM6rMTnvfYVFIn+4/FbSDLB7t3cmhdsLiXPDvjpo+7stB3ZwkgeBxbYLcQPAzEC70gpjwUpZ8b5oojEoxmdxV3zKvZOUHp1VBedpSfonLkS2xI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732091978; c=relaxed/simple; bh=uCabY3aXdU8knrzyUvKDoBC/ts+x8ZTTZaaPEX0zYC8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IUyiA3qGWTHdM2E9I6JQLwChaa5pZk2D3K7RduXEzAbdzPwV/Gpi9jKi4iyI5sFnf8XYjKSdUkTo+OsUeNdNut9HzD758SZHz/hcbQUG7N6Bl1OYA0rn93CRoBOvN/+5WLaIWAsdm3LvzUas0XZI817LbizpfyJkKCEuZrVRCEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dXV7Z/pm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dXV7Z/pm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11A8EC4CECD; Wed, 20 Nov 2024 08:39:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732091978; bh=uCabY3aXdU8knrzyUvKDoBC/ts+x8ZTTZaaPEX0zYC8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dXV7Z/pm3H/r3AO4Tq9FfR6TpXz+12dGVNcVBe4YnWLALAydN5KQPUMUuyqP+lzGc 6pS5yeOLEaQCj9p+3eAP2Up0tsIR/2X3YGP8WwavkFt/ebx2YOXWau1ZoMNTzhIL0J CSS/EhklqMdNOKXRwDg1CR+A8/3cumO0ZcW5fBY/G24NJgjXhbmXVSnrCvD/LQIf6f pDcGUqoBhfz9LqAWWJnalmmhYtPVxk/ZNYl7W1+c3Cmop1xfglJ4rRo9Wv+fNQYlV6 uki1XOe5gh/lex7JBneDXof+3DxhhFljG2uhkIMBoMeaw88+NpD7XSILNWFkP9TYsK 1xlZ63Jhz8Izg== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1tDgFD-000000007wu-3WTl; Wed, 20 Nov 2024 09:39:27 +0100 Date: Wed, 20 Nov 2024 09:39:27 +0100 From: Johan Hovold To: Dmitry Baryshkov Cc: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jeykumar Sankaran , stable@vger.kernel.org, Leonard Lausen Subject: Re: [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector Message-ID: References: <20240802-dpu-fix-wb-v2-0-7eac9eb8e895@linaro.org> <20240802-dpu-fix-wb-v2-1-7eac9eb8e895@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240802-dpu-fix-wb-v2-1-7eac9eb8e895@linaro.org> On Fri, Aug 02, 2024 at 10:47:33PM +0300, Dmitry Baryshkov wrote: > During suspend/resume process all connectors are explicitly disabled and > then reenabled. However resume fails because of the connector_status check: > > [ 1185.831970] [dpu error]connector not connected 3 Please also include the follow-on resume error. I'm seeing: [dpu error]connector not connected 3 [drm:drm_mode_config_helper_resume [drm_kms_helper]] *ERROR* Failed to resume (-22) and say something about that this can prevent displays from being enabled on resume in some setups (preferably with an explanation why if you have one). > It doesn't make sense to check for the Writeback connected status (and > other drivers don't perform such check), so drop the check. > > Fixes: 71174f362d67 ("drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c") I noticed that the implementation had this status check also before 71174f362d67 ("drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c"). Why did this not cause any trouble back then? Or is this not the right Fixes tag? > Cc: stable@vger.kernel.org > Reported-by: Leonard Lausen > Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/57 Perhaps you can include mine an György's reports here too. > Signed-off-by: Dmitry Baryshkov With the above addressed: Reviewed-by: Johan Hovold Tested-by: Johan Hovold Johan