From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Krishna chaitanya chundru <quic_krichai@quicinc.com>,
"Manivannan Sadhasivam" <mani@kernel.org>
Cc: <mhi@lists.linux.dev>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_vbadigan@quicinc.com>,
<quic_ramkri@quicinc.com>, <quic_skananth@quicinc.com>,
<quic_parass@quicinc.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH v2] bus: mhi: host: Add alignment check for event ring read pointer
Date: Fri, 3 Nov 2023 08:54:47 -0600 [thread overview]
Message-ID: <a04c7754-e807-9b5c-8565-e92ab513af94@quicinc.com> (raw)
In-Reply-To: <20231031-alignment_check-v2-1-1441db7c5efd@quicinc.com>
On 10/31/2023 3:51 AM, Krishna chaitanya chundru wrote:
> Though we do check the event ring read pointer by "is_valid_ring_ptr"
> to make sure it is in the buffer range, but there is another risk the
> pointer may be not aligned. Since we are expecting event ring elements
> are 128 bits(struct mhi_ring_element) aligned, an unaligned read pointer
> could lead to multiple issues like DoS or ring buffer memory corruption.
>
> So add a alignment check for event ring read pointer.
>
> Fixes: ec32332df764 ("bus: mhi: core: Sanity check values from remote device before use")
> cc: stable@vger.kernel.org
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
next prev parent reply other threads:[~2023-11-03 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 9:51 [PATCH v2] bus: mhi: host: Add alignment check for event ring read pointer Krishna chaitanya chundru
2023-11-01 5:17 ` Manivannan Sadhasivam
2023-11-01 5:20 ` Krishna Chaitanya Chundru
2023-11-03 14:54 ` Jeffrey Hugo [this message]
2023-11-05 8:33 ` Manivannan Sadhasivam
2023-11-09 16:34 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a04c7754-e807-9b5c-8565-e92ab513af94@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=quic_krichai@quicinc.com \
--cc=quic_parass@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_skananth@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox