From: Viresh Kumar <viresh.kumar@linaro.org>
To: rjw@rjwysocki.net, shawn.guo@linaro.org
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, arvind.chauhan@arm.com,
sboyd@codeaurora.org, linux-arm-msm@vger.kernel.org,
spk.linux@gmail.com, thomas.ab@samsung.com, nm@ti.com,
t.figa@samsung.com, Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH 11/14] cpufreq: cpu0: Make allocate_resources() work for any CPU
Date: Tue, 1 Jul 2014 22:02:40 +0530 [thread overview]
Message-ID: <a05014a959751c1fdd413a2553faf93e443aa5dc.1404231535.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1404231535.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1404231535.git.viresh.kumar@linaro.org>
Currently allocate_resources() supports only CPU0 and it would need to allocate
resources for any CPU going forward.
Add another argument to it, i.e. cpu, and update code accordingly.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/cpufreq-cpu0.c | 30 +++++++++++++++++-------------
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
index 17001a8..44633f6 100644
--- a/drivers/cpufreq/cpufreq-cpu0.c
+++ b/drivers/cpufreq/cpufreq-cpu0.c
@@ -106,7 +106,7 @@ static int cpu0_set_target(struct cpufreq_policy *policy, unsigned int index)
return ret;
}
-static int allocate_resources(struct device **cdev,
+static int allocate_resources(int cpu, struct device **cdev,
struct regulator **creg, struct clk **cclk)
{
struct device *cpu_dev;
@@ -115,24 +115,28 @@ static int allocate_resources(struct device **cdev,
int ret = 0;
char *reg_cpu0 = "cpu0", *reg_cpu = "cpu", *reg;
- cpu_dev = get_cpu_device(0);
+ cpu_dev = get_cpu_device(cpu);
if (!cpu_dev) {
- pr_err("failed to get cpu0 device\n");
+ pr_err("failed to get cpu%d device\n", cpu);
return -ENODEV;
}
/* Try "cpu0" for older DTs */
- reg = reg_cpu0;
+ if (!cpu)
+ reg = reg_cpu0;
+ else
+ reg = reg_cpu;
try_again:
cpu_reg = regulator_get_optional(cpu_dev, reg);
if (IS_ERR(cpu_reg)) {
/*
- * If cpu0 regulator supply node is present, but regulator is
+ * If cpu's regulator supply node is present, but regulator is
* not yet registered, we should try defering probe.
*/
if (PTR_ERR(cpu_reg) == -EPROBE_DEFER) {
- dev_err(cpu_dev, "cpu0 regulator not ready, retry\n");
+ dev_err(cpu_dev, "cpu%d regulator not ready, retry\n",
+ cpu);
return -EPROBE_DEFER;
}
@@ -142,8 +146,8 @@ try_again:
goto try_again;
}
- dev_warn(cpu_dev, "failed to get cpu0 regulator: %ld\n",
- PTR_ERR(cpu_reg));
+ dev_warn(cpu_dev, "failed to get cpu%d regulator: %ld\n",
+ cpu, PTR_ERR(cpu_reg));
}
cpu_clk = clk_get(cpu_dev, NULL);
@@ -157,11 +161,12 @@ try_again:
* registered, we should try defering probe.
*/
if (PTR_ERR(cpu_clk) == -EPROBE_DEFER) {
- dev_err(cpu_dev, "cpu0 clock not ready, retry\n");
+ dev_err(cpu_dev, "cpu%d clock not ready, retry\n", cpu);
ret = -EPROBE_DEFER;
} else {
ret = PTR_ERR(cpu_clk);
- dev_err(cpu_dev, "failed to get cpu0 clock: %d\n", ret);
+ dev_err(cpu_dev, "failed to get cpu%d clock: %d\n", ret,
+ cpu);
}
} else {
*cdev = cpu_dev;
@@ -184,8 +189,7 @@ static int cpu0_cpufreq_init(struct cpufreq_policy *policy)
unsigned int transition_latency;
int ret;
- /* We only support cpu0 currently */
- ret = allocate_resources(&cpu_dev, &cpu_reg, &cpu_clk);
+ ret = allocate_resources(policy->cpu, &cpu_dev, &cpu_reg, &cpu_clk);
if (ret) {
pr_err("%s: Failed to allocate resources\n: %d", __func__, ret);
return ret;
@@ -322,7 +326,7 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev)
*
* FIXME: Is checking this only for CPU0 sufficient ?
*/
- ret = allocate_resources(&cpu_dev, &cpu_reg, &cpu_clk);
+ ret = allocate_resources(0, &cpu_dev, &cpu_reg, &cpu_clk);
if (ret)
return ret;
--
2.0.0.rc2
next prev parent reply other threads:[~2014-07-01 16:32 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 16:32 [PATCH 00/14] cpufreq: cpu0: Extend support beyond CPU0, V2 Viresh Kumar
2014-07-01 16:32 ` [PATCH 01/14] of: Create of_property_match() Viresh Kumar
2014-07-01 16:32 ` [PATCH 02/14] clk: Create of_clk_shared_by_cpus() Viresh Kumar
2014-07-01 18:00 ` Stephen Boyd
2014-07-02 1:57 ` Viresh Kumar
2014-07-09 14:38 ` Santosh Shilimkar
2014-07-09 15:20 ` Viresh Kumar
[not found] ` <5f7164d789e87c62d722b575980c92dfd0504334.1404231535.git.viresh.kumar@linar o.org>
2014-07-28 14:01 ` Grant Likely
2014-07-01 16:32 ` [PATCH 03/14] cpufreq: Add support for per-policy driver data Viresh Kumar
2014-07-09 14:33 ` Santosh Shilimkar
2014-07-09 15:07 ` Viresh Kumar
2014-07-01 16:32 ` [PATCH 04/14] cpufreq: cpu0: Add Module Author Viresh Kumar
2014-07-09 14:42 ` Santosh Shilimkar
2014-07-09 15:08 ` Viresh Kumar
2014-07-09 15:24 ` Santosh Shilimkar
2014-07-01 16:32 ` [PATCH 05/14] cpufreq: cpu0: don't validate clock on clk_put() Viresh Kumar
2014-07-09 14:42 ` Santosh Shilimkar
2014-07-01 16:32 ` [PATCH 06/14] cpufreq: cpu0: defer probe if clock isn't registered yet Viresh Kumar
2014-07-02 5:53 ` Shawn Guo
2014-07-02 5:55 ` Viresh Kumar
2014-07-02 11:32 ` Viresh Kumar
2014-07-03 0:38 ` Stephen Boyd
2014-07-03 2:19 ` Viresh Kumar
2014-07-09 14:43 ` Santosh Shilimkar
2014-07-01 16:32 ` [PATCH 07/14] cpufreq: cpu0: OPPs can be populated at runtime Viresh Kumar
2014-07-01 18:02 ` Stephen Boyd
2014-07-02 2:03 ` Viresh Kumar
2014-07-02 4:03 ` [PATCH V2 Resend " Viresh Kumar
2014-07-09 14:44 ` [PATCH " Santosh Shilimkar
2014-07-09 15:09 ` Viresh Kumar
2014-07-10 11:19 ` Viresh Kumar
2014-07-10 12:39 ` Nishanth Menon
2014-07-10 13:31 ` Santosh Shilimkar
2014-07-10 13:36 ` Viresh Kumar
2014-07-01 16:32 ` [PATCH 08/14] cpufreq: cpu0: use dev_{err|warn|dbg} instead of pr_{err|warn|debug} Viresh Kumar
2014-07-09 14:45 ` Santosh Shilimkar
2014-07-01 16:32 ` [PATCH 09/14] cpufreq: cpu0: Move per-cluster initialization code to ->init() Viresh Kumar
2014-07-03 0:43 ` Stephen Boyd
2014-07-03 2:11 ` Viresh Kumar
2014-07-09 14:53 ` Santosh Shilimkar
2014-07-09 15:17 ` Viresh Kumar
2014-07-09 15:26 ` Santosh Shilimkar
2014-07-09 15:27 ` Viresh Kumar
2014-07-09 15:29 ` Santosh Shilimkar
2014-07-09 15:33 ` Viresh Kumar
2014-07-01 16:32 ` [PATCH 10/14] cpufreq: cpu0: try regulators with name "cpu-supply" Viresh Kumar
2014-07-01 16:32 ` Viresh Kumar [this message]
2014-07-01 16:32 ` [PATCH 12/14] cpufreq: cpu0: Extend support beyond CPU0 Viresh Kumar
2014-07-02 4:03 ` [PATCH V2 Resend " Viresh Kumar
2014-07-01 16:32 ` [PATCH 13/14] cpufreq: cpu0: rename driver and internals to 'cpufreq_generic' Viresh Kumar
2014-07-01 16:32 ` [PATCH 14/14] cpufreq: generic: set platform_{driver|device} '.name' to 'cpufreq-generic' Viresh Kumar
2014-07-02 4:12 ` [PATCH 00/14] cpufreq: cpu0: Extend support beyond CPU0, V2 Viresh Kumar
2014-07-03 1:24 ` Stephen Boyd
2014-07-03 2:44 ` Viresh Kumar
2014-07-03 22:16 ` Mike Turquette
2014-07-04 4:21 ` Viresh Kumar
2014-07-08 4:50 ` Viresh Kumar
2014-07-09 17:41 ` Stephen Boyd
2014-07-16 16:01 ` Viresh Kumar
2014-07-16 21:18 ` Rafael J. Wysocki
2014-07-17 0:28 ` Viresh Kumar
2014-07-17 7:35 ` Thomas Petazzoni
2014-07-17 7:41 ` Viresh Kumar
2014-07-18 1:02 ` Rafael J. Wysocki
2014-07-18 4:17 ` Viresh Kumar
[not found] ` <CAKohpomKzK8pMJs1gv+uXxhd17HtCQyfjSnVYw9KpGz6FwbgDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-24 10:48 ` Viresh Kumar
2014-07-25 14:29 ` Rob Herring
[not found] ` <CAL_JsqKqCeU0zs+rS1vxsOeh=Kuw_-gaVHtGU76Lb6TchCTytw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-25 14:34 ` Viresh Kumar
2014-07-25 15:41 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a05014a959751c1fdd413a2553faf93e443aa5dc.1404231535.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=arvind.chauhan@arm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=shawn.guo@linaro.org \
--cc=spk.linux@gmail.com \
--cc=t.figa@samsung.com \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).